-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robert/build/tests #145
Robert/build/tests #145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
=======================================
Coverage 88.60% 88.60%
=======================================
Files 29 29
Lines 1667 1667
=======================================
Hits 1477 1477
Misses 190 190 ☔ View full report in Codecov by Sentry. |
.github/workflows/release.yml
Outdated
|
||
- name: Install dependencies | ||
run: | | ||
poetry install --all-extras |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we needed this step afterall?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had this as a todo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/release.yml
Outdated
- name: Publish to TestPyPI | ||
env: | ||
POETRY_PYPI_TOKEN_TESTPYPI: ${{ secrets.TESTPYPI }} | ||
run: poetry config repositories.test-pypi https://test.pypi.org/legacy/; poetry config pypi-token.test-pypi $POETRY_PYPI_TOKEN_TESTPYPI; poetry publish --repository test-pypi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it dawns on me that if I can't get access to the official redisvl
test-pypi index, we will have to comment out the pre-checks here because right now this leans on the custom redisvl-test
package which we won't be able to support. Although maybe there is a setting for this in the pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we're unfortunately still reliant on Sam unless we can get that oicd work around to happen
.github/workflows/release.yml
Outdated
on: | ||
# TODO: remove | ||
push: | ||
branches: [ robert/build/tests ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep just marking so we remember to remove this :)
b7e67ce
to
16049f0
Compare
16049f0
to
744fd4e
Compare
Notes: - added changes for poetry build cycle and push to test-pypi - updated test_cov script to properly fail with failed tests --------- Co-authored-by: Tyler Hutcherson <[email protected]>
Notes:
todo before merge: