Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robert/build/tests #145

Merged
merged 3 commits into from
May 1, 2024
Merged

Robert/build/tests #145

merged 3 commits into from
May 1, 2024

Conversation

rbs333
Copy link
Collaborator

@rbs333 rbs333 commented Apr 30, 2024

Notes:

  • adding changes for poetry build cycle and push to test-pypi
  • updates test_cov script to properly fail with failed tests

todo before merge:

  • remove push branch option
  • replace pip install with poetry
  • grok test-pypi cache problem with version

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (7faaf4e) to head (744fd4e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files          29       29           
  Lines        1667     1667           
=======================================
  Hits         1477     1477           
  Misses        190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
scripts.py Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved

- name: Install dependencies
run: |
poetry install --all-extras
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we needed this step afterall?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had this as a todo

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

So dropping this we get no model named pytest when we try and run tests.

- name: Publish to TestPyPI
env:
POETRY_PYPI_TOKEN_TESTPYPI: ${{ secrets.TESTPYPI }}
run: poetry config repositories.test-pypi https://test.pypi.org/legacy/; poetry config pypi-token.test-pypi $POETRY_PYPI_TOKEN_TESTPYPI; poetry publish --repository test-pypi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it dawns on me that if I can't get access to the official redisvl test-pypi index, we will have to comment out the pre-checks here because right now this leans on the custom redisvl-test package which we won't be able to support. Although maybe there is a setting for this in the pyproject.toml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we're unfortunately still reliant on Sam unless we can get that oicd work around to happen

on:
# TODO: remove
push:
branches: [ robert/build/tests ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep just marking so we remember to remove this :)

@tylerhutcherson tylerhutcherson self-requested a review May 1, 2024 18:15
@tylerhutcherson tylerhutcherson marked this pull request as ready for review May 1, 2024 18:16
@tylerhutcherson tylerhutcherson merged commit d7526b5 into main May 1, 2024
20 checks passed
@tylerhutcherson tylerhutcherson deleted the robert/build/tests branch May 1, 2024 18:22
justin-cechmanek pushed a commit that referenced this pull request May 6, 2024
Notes:
- added changes for poetry build cycle and push to test-pypi
- updated test_cov script to properly fail with failed tests

---------

Co-authored-by: Tyler Hutcherson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants