Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
This PR resolves three classes of warnings and errors that Sphinx reports when building the documentation (recent example; click the
python -m sphinx
accordion to see the details):Note
The test suite is failing due to the release of hiredis 3.0.0, released ~4 hours ago. The failures are unrelated to this PR. See #3327.
Warning
This work revealed a significant problem that flake8 reported exactly once but then failed to ever report again on subsequent runs (and fails to report in CI, as well)!
The
Script
class is defined twice inredis/commands/core.py
, at lines 5462 and 6286:redis-py/redis/commands/core.py
Line 5462 in 2ffcac3
redis-py/redis/commands/core.py
Line 6286 in 2ffcac3
git blame
shows that both definitions were created on 2022-02-22, by different authors, within 1.5 hours of each other. I intend to submit a PR to delete the first definition.