BZ #1247684 Puppet Errors with cinder Dell SC multibackend

[rajinir]

https://bugzilla.redhat.com/show_bug.cgi?id=1247684

The directory structure of dellsc::volume did not match the name of the define,
causing puppet to be unable to find the requested define.

And there was typo in evaluating the last index when defining types.

[arkadykanevsky]

Why are we dropping iscsi?
I think we just need to have consistent name. dell_sc_iscsi does make sense to me. We use that for documentation for kilo.

[rajinir]

It is just a directory name. We will use dellfc for fiber channel

[arkadykanevsky]

we expect that in longer term we will have both eql and sc under dell. Thus, I want correct naming conversion to handle it. Leave particular to you.

[jguiditta]

perhaps then this should be changed to be:
(directory structure) manifests/dell/sc_iscsi/volume.pp
resulting in a define with the name:
quickstack::dell::sc_iscsi::volume
Would that be clearer and allow you to fold the eql code into the quickstack::dell namespace as desired?

[arkadykanevsky]

fine with me

[rajinir]

Updated the patch with new dir structure

[jguiditta]

@rajinir these changes look reasonable to me. As I have no way to properly test them, do they resolve the issues you saw previously?

[rajinir]

These changes are good to go. But got an error further
Error: Could not retrieve catalog from remote server: Could not intern from text/pson: Could not intern from data: Could not find relationship target "Cinder::Type[]"
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

[jguiditta]

Repeating what I said in BZ in case you see this first:

Ok, got it. In quickstack::cinder_volume_types, on line 39, it has:
$dell_sc_last_index = size($backend_dell_sc) - 1

If I change that to:
$dell_sc_last_index = size($backend_dell_sc_name) - 1

(which matches other types) then the error goes away for me.

[jguiditta]

Also, could you update the commit message on your next push? We have a format that makes it easier for me to generate a list of changes between releases:

BZ #12345 - Short title.

<link to bug>

Any additional detail desired.

Thanks!

[rajinir]

Puppet run finished with success. Tested that it generates the cinder.conf file correctly

[jguiditta]

Excellent, then unless @arkadykanevsky has any other concerns, I think this is ready to merge

[arkadykanevsky]

+1