Fix errors on inactive nodes. #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the inactive nodes in a cluster would still attempt to call the database class and create their DBs and users, which of course, would fail, since there was no mysql running on those nodes. This patch simply leverages the same info as our (soon to be cleaned up) execs to determine if those database calls should happen or not. However, it currently has the problem that using the fact fails on the first run, since mysql is not yet running. This still needs more work, but at least gets us closer to working, as nodes should eventually show success instead of always failing if they are not the active mysql host.
|
Ack. Using this added facter variable, the cluster hosts no longer show an error status after a puppet run. [Separate issue: puppet agent needs to be run twice for opentack db users to be configured] |
cwolferh
added a commit
that referenced
this pull request
Oct 22, 2013
Fix errors on inactive nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the inactive nodes in a cluster woudl still attempt to call the
database class and create their DBs and users, which of course, would fail,
since there was no mysql runnign on those nodes. This patch simply leverages
the file created by our (soon to be cleaned up) execs to determine if those
database calls should happen or not.