Fix endpoint URLs, extract Ceilometer #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Point the endpoint URLs to correct public and private addresses according to this guide: http:https://docs.openstack.org/security-guide/content/ch021_paste-and-middleware.html
Move Ceilometer related parts of controller classes into ceilometer_controller.pp and include that class it in controller classes.
|
Yes, that sounds reasonable to me. |
jguiditta
added a commit
that referenced
this pull request
Oct 4, 2013
Fix endpoint URLs, extract Ceilometer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had public/private addresses mixed up in keystone service endpoint catalog, which is now fixed.
Here's output of
keystone service-list; keystone endpoint-list. (.122.is private network,.123.is public.)before fix: http:https://fpaste.org/44308/8927721/raw/
fixed: http:https://fpaste.org/44309/80892809/raw/
Ceilometer parts are extracted from controller classes into a separate class to reduce duplication and size of the controller classes.