sync with upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(fastcall): Int64Representation * Add tests, new_with_bigint API * Fix build, actually
By default, copying a file will preserve its mode and ownership attributes. This is an issue when copying the V8 archive from a read-only filesystem since the archive file also becomes read-only, so subsequent builds will fail. We now create a new destination file and copy the content of the archive to it, this ensures the destination file has the default attributes.
Some fixes around one-byte strings: - `is_onebyte` was calling the wrong v8 API. - We didn't have a way to write one-byte strings with uninitialized buffers - (bonus) The test_string method was quite slow making testing a bit of a pain
Co-authored-by: Bartek Iwańczuk <[email protected]>
…d, ResourceName, SourceMapUrl}` bindings (#1250)
chore: Add copy, clone and debug to some types
…ssy (#1256) Co-authored-by: Bartek Iwańczuk <[email protected]>
this warning only occurs when using the library as a dependency.
warning: unused return value of `Box::<T>::from_raw` that must be used
--> /rusty_v8/src/scope.rs:1092:16
|
1092 | unsafe { Box::from_raw(root) };
| ^^^^^^^^^^^^^^^^^^^
|
= note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box`
= note: `#[warn(unused_must_use)]` on by default
#1275) MSVC and Itanium C++ ABIs agree that for simple inheritance the basic structure of a vtable contains metadata fields at a "negative offset" from the vtable pointer, and at zero or positive offsets come the virtual function pointers in the order of declaration. The only difference between the two is that MSVC only places the virtual deleting destructor in the vtable while Itanium ABI places both the deleting and the complete object destructors in it, leading to a vtable that is one pointer larger in Itanium / on Linux. Also MSVC only has a single metadata field instead of two for Itanium. Itanium inlines the base offset into the vtable while MSVC keeps it in what is essentially the entry point into the type info data. Since the two are so similar, creating a custom vtable on Rust-side is pretty easy and can be done entirely at compile-time, meaning that instances of the class can also be created entirely at compile time. This leads to fully const external strings being possible.
Fix missing ASCII assertion, assert length
This commit adds two new types of scopes: - DisallowJavascriptExecutionScope - AllowJavascriptExecutionScope The first one can be used to prevent execution of JavaScript (with customizable behavior on an attempt of executing JS, eg. crashing the process); while the second one can be constructed from the first to temporarily enable executing JS. These are useful for "value serializers" to prevent user defined objects from causing unintended behavior. --------- Co-authored-by: Bartek Iwańczuk <[email protected]>
The memory leak caused by the EPT table not being subject to garbage collection is apparently still there.
Bumps [bumpalo](https://github.com/fitzgen/bumpalo) from 3.9.1 to 3.13.0. - [Changelog](https://github.com/fitzgen/bumpalo/blob/main/CHANGELOG.md) - [Commits](fitzgen/bumpalo@3.9.1...3.13.0) --- updated-dependencies: - dependency-name: bumpalo dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matt Mastracci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.