Fixed invalid timing async_shutdown handler call. #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redboltz
force-pushed
the
fix_invalid_timing_async_shutdown_handler_call
branch
3 times, most recently
from
18d8950
to
92c2eea
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #950 +/- ##
==========================================
+ Coverage 83.08% 83.12% +0.03%
==========================================
Files 66 65 -1
Lines 10391 9882 -509
==========================================
- Hits 8633 8214 -419
+ Misses 1758 1668 -90 |
If the 2nd async_shutdown() is called during the 1st async_shutdown processing, then the 2nd async_shutdown() is called immediately. It should be called the 1st handler calling timing.
redboltz
force-pushed
the
fix_invalid_timing_async_shutdown_handler_call
branch
from
92c2eea
to
6b24371
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the 2nd async_shutdown() is called during the 1st async_shutdown processing, then the 2nd async_shutdown() is called immediately. It should be called the 1st handler calling timing.