Kleunen master mg2 #921
Merged
Kleunen master mg2 #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibe to topic filter
- Changed allow/deny style - Renamed group to groups
Co-authored-by: Takatoshi Kondo <[email protected]>
redboltz
force-pushed
the
kleunen-master-mg2
branch
from
560ec02
to
267d3a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
==========================================
- Coverage 83.05% 83.05% -0.01%
==========================================
Files 63 64 +1
Lines 9929 10356 +427
==========================================
+ Hits 8247 8601 +354
- Misses 1682 1755 +73 |
|
Yes, this looks ok. Only coding style changes, all test pass. Indeed it has become a massive PR. |
redboltz
force-pushed
the
kleunen-master-mg2
branch
from
267d3a7
to
85cfa6f
Compare
|
I force updated the PR. |
Refined minor code issues. - Removed "CNAME" from auth.json and tests. - Added plain_password for auth.json example. - Removed unused constants. - Renamed cname related variable name to cn - Added `const` to some member functions. - Removed const& from string_view.
redboltz
force-pushed
the
kleunen-master-mg2
branch
from
85cfa6f
to
85271f6
Compare
|
Looks good |
|
Merged. Thank you for the great work !! Could you update https://github.com/redboltz/mqtt_cpp/wiki/Authentication-and-Authorization ? |
|
Excellent. I will update the documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.