Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified async/sync selector for automatic operation. #857

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

redboltz
Copy link
Owner

@redboltz redboltz commented Sep 9, 2021

  • Renamed client's async_store_send to async_operation.
    Now it is not only for sending stored messages but also for all automatic messages.
  • Removed set_auto_pub_response()'s 2nd parameter.
  • Removed set_async_notify() for DISCONNECT/CONNACK.
  • Removed set_async_pingreq().
  • Added set_async_operation(). for all automatic operations.

- Renamed client's async_store_send to async_operation.
  Now it is not only for sending stored messages but also for all automatic messages.
- Removed set_auto_pub_response()'s 2nd parameter.
- Removed set_async_notify() for DISCONNECT/CONNACK.
- Removed set_async_pingreq().
- Added set_async_operation(). for all automatic operations.
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #857 (0131041) into master (70e45c2) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
- Coverage   83.52%   83.51%   -0.01%     
==========================================
  Files          62       62              
  Lines        9506     9502       -4     
==========================================
- Hits         7940     7936       -4     
  Misses       1566     1566              

@redboltz redboltz merged commit 58d9354 into master Sep 9, 2021
@redboltz redboltz deleted the unified_auto_async branch September 9, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant