Updated certificate function call. #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced use_certificate_file with use_certificate_chain_file. If certificate file contians one certification, both ok. However, if the certificate file contains intermidiate certificate and server certificate, then only use_certificate_chain_file works. See https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_use_certificate.html
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 62 62
Lines 9274 9274
=======================================
Hits 7512 7512
Misses 1762 1762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced use_certificate_file with use_certificate_chain_file.
If certificate file contians one certification, both ok.
However, if the certificate file contains intermidiate certificate and
server certificate, then only use_certificate_chain_file works.
See
https://www.openssl.org/docs/man1.1.1/man3/SSL_CTX_use_certificate.html