Fixed TopicAlias functionality. #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The the TopicAlias map should be cleared on disconnection. If the inflight message has the TopicAlias property, remove it. If the inflight message has the empty TopicName and the TopicAlias, the original TopicName is recovered from the TopicAlias at the first sent, and remove TopicAlias property. It works well with mosquitto MQTT broker. The original mqtt_cpp implementation cause protocol error because of using cleared topic alias on resend.
Codecov Report
@@ Coverage Diff @@
## master #783 +/- ##
==========================================
- Coverage 85.16% 85.03% -0.13%
==========================================
Files 63 64 +1
Lines 8747 8932 +185
==========================================
+ Hits 7449 7595 +146
- Misses 1298 1337 +39 |
|
I reported the issue to OASIS. |
|
Test with mosquitto broker has also been successfully finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The the TopicAlias map should be cleared on disconnection.
If the inflight message has the TopicAlias property, remove it.
If the inflight message has the empty TopicName and the TopicAlias,
the original TopicName is recovered from the TopicAlias at the first
sent, and remove TopicAlias property.
It works well with mosquitto MQTT broker.
The original mqtt_cpp implementation cause protocol error because of
using cleared topic alias on resend.