Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #768. #769

Merged
merged 2 commits into from
Dec 19, 2020
Merged

Fixed #768. #769

merged 2 commits into from
Dec 19, 2020

Conversation

redboltz
Copy link
Owner

The broker sent CONNACK even if MQTT connection hadn't been established.
It caused assertion failed.

In this case, the broker should simply close connection.

The broker sent CONNACK even if MQTT connection hadn't been established.
It caused assertion failed.

In this case, the broker should simply close connection.
@kleunen
Copy link
Contributor

kleunen commented Dec 18, 2020

let me test if this is sufficient to resolve assertion

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #769 (fca6804) into master (abb4f52) will increase coverage by 0.05%.
The diff coverage is 68.18%.

@@            Coverage Diff             @@
##           master     #769      +/-   ##
==========================================
+ Coverage   85.19%   85.24%   +0.05%     
==========================================
  Files          61       61              
  Lines        8645     8661      +16     
==========================================
+ Hits         7365     7383      +18     
+ Misses       1280     1278       -2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants