Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect include of boost unit test in global_fixture.hpp #721

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

kleunen
Copy link
Contributor

@kleunen kleunen commented Nov 11, 2020

The header file 'global_fixture.hpp' was including the wrong boost unit test header file, causing a compilation error on windows.
http:https://boost.2283326.n4.nabble.com/Boost-unit-test-cpp-problem-when-try-to-compile-simple-program-td2596687.html

You need different include than. Can't have it both ways. Either you include
library implementation or you link with it.

Use boost/test/unit_test.hpp

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #721 (6f0c7b3) into master (3234099) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #721   +/-   ##
=======================================
  Coverage   82.06%   82.06%           
=======================================
  Files          47       47           
  Lines        7082     7082           
=======================================
  Hits         5812     5812           
  Misses       1270     1270           

@redboltz
Copy link
Owner

Some of azure build pipelines are failed.
I re-run failed build but got the same result.

It seems that the error is caused by actions/runner-images#1847
I guess that some of your builds just across vm image update.
It seems that you need to update the boost version.

@kleunen
Copy link
Contributor Author

kleunen commented Nov 13, 2020

It seems that you need to update the boost version.

It took me a moment, to understand what you were saying

@redboltz
Copy link
Owner

Thank you for updating!
Your fix works perfectly.

@redboltz redboltz merged commit 2be3b49 into redboltz:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants