Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of performance optimizations to subcription_map and retained_topic_map #691

Merged
merged 1 commit into from
Oct 18, 2020

Conversation

kleunen
Copy link
Contributor

@kleunen kleunen commented Oct 17, 2020

No description provided.

@redboltz
Copy link
Owner

redboltz commented Oct 18, 2020

CI error reported.

https://github.com/redboltz/mqtt_cpp/pull/691/checks?check_run_id=1269138667#step:6:32

Getting value function of MQTT_NS::optional is value() not get().

MQTT_NS::optional could be std::optional or boost::optional. Both have value() function.
boost::optional used to only have get(), but now (at least mqtt_cpp requirement version of boost), it also have value() to meet std::optional.
On the other hand std::optional doesn't have get(). So value() is good choice.

@redboltz
Copy link
Owner

I will fix it during merge process.

@redboltz redboltz merged commit 4e2b49a into redboltz:master Oct 18, 2020
@redboltz
Copy link
Owner

See added commits https://github.com/redboltz/mqtt_cpp/commits/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants