Refined online and offline sessions and subscribers. #678
Conversation
online and offline subscribers has common member function `deliver`. It is a preparation for cross collection roundrobin iteration for shared subscriptions in the future. Apply coding rules. Renamed types and variables. Refined logs.
Codecov Report
@@ Coverage Diff @@
## master #678 +/- ##
==========================================
- Coverage 82.69% 82.67% -0.02%
==========================================
Files 46 46
Lines 7077 7078 +1
==========================================
Hits 5852 5852
- Misses 1225 1226 +1 |
| @@ -122,7 +122,7 @@ BOOST_LOG_ATTRIBUTE_KEYWORD(address, "MqttAddress", void const*) | |||
|
|
|||
| #if !defined(MQTT_ADD_VALUE) | |||
|
|
|||
| #define MQTT_ADD_VALUE(name, val) boost::log::add_value((name), (val)) | |||
| #define MQTT_ADD_VALUE(name, val) boost::log::add_value((MQTT_NS::name), (val)) | |||
There was a problem hiding this comment.
I don't understand why you added MQTT_NS:: to "name" ?
There was a problem hiding this comment.
In some of the log code below, this has a strange outcome.
MQTT_ADD_VALUE(address, spep.get()) -> boost::log::add_value(MQTT_NS::address, spep.get())
There was a problem hiding this comment.
It is the same reason as MQTT_LOG(chan, sev) 's sev.
https://github.com/redboltz/mqtt_cpp/blob/master/include/mqtt/log.hpp#L118
| auto add_or_overwrite_sub = | ||
| [&](MQTT_NS::buffer topic, MQTT_NS::qos qos_value, MQTT_NS::rap rap_value = MQTT_NS::rap::dont) { | ||
| auto& idx = subs_online_.get<tag_con_topic>(); | ||
| auto r = idx.equal_range(std::make_tuple(spep, topic)); |
There was a problem hiding this comment.
Instead of equal_range, use idx.find(std::make_tuple(spep, topic)).
There was a problem hiding this comment.
No, it is for emplace_hint.
| @@ -839,6 +846,37 @@ class test_broker { | |||
|
|
|||
| auto& ep = *spep; | |||
|
|
|||
| std::vector<bool> new_sub; | |||
There was a problem hiding this comment.
Recommend making a member variable, so that after the broker has been online for a while, it doesn't have to do new allocations every time.
There was a problem hiding this comment.
It is temporary variable. SUBSCRIBE packet has multiple entries. It is very small number basically. new_sub marks which entry is new one. I believe that it is better for temporary variable.
online and offline subscribers has common member function
deliver.It is a preparation for cross collection roundrobin iteration for shared
subscriptions in the future.
Apply coding rules.
Renamed types and variables.
Refined logs.