Fixed topic_alias_recv test failure. #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redboltz
force-pushed
the
fix_topic_alias_test
branch
5 times, most recently
from
a66ab0d
to
6f9ec28
Compare
Added error code matching. The error code operation cancelled sometimes happen. It depends on environment and timing.
redboltz
force-pushed
the
fix_topic_alias_test
branch
from
6f9ec28
to
93bb806
Compare
|
I noticed that many pull requests outputs error message on the testing. When I merged Topic Alias functionality the last merged pull request, no errors are reported. But I re-run the tests, I got an error that is the same as many recent pull requests. The error should be fixed by this pull request. |
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 82.68% 82.69%
=======================================
Files 46 46
Lines 7076 7077 +1
=======================================
+ Hits 5851 5852 +1
Misses 1225 1225 |
When disconnect timeout happens, h_close should be callned not h_error, because disconnect is requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debug.