Fix PartialFreeSpaceModifier deleting non-overlapping children #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which are next to the freed region, but not overlapping.
rbs-jacob
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR
This change prevents
_find_and_delete_overlapping_childrenfrom deleting children which are next to the freed region, but not overlapping.Please describe the changes in your request.
The
ResourceFilterbounds searched for MemoryRegion children within the freed range, but would also include MemoryRegions which start at the end of the freed range. This change fixes the bounds such that it will only find MemoryRegions which overlap with the freed range.