Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discovery.k8s.io/v1 EndpointSlice die #145

Merged
merged 1 commit into from
Jun 8, 2024

Conversation

scothis
Copy link
Collaborator

@scothis scothis commented Jun 8, 2024

Resolves #144

@scothis scothis requested a review from mamachanko June 8, 2024 14:10
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 10.45%. Comparing base (6bafe0f) to head (306fca9).

Files Patch % Lines
apis/discovery/v1/endpointslice.go 0.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   10.59%   10.45%   -0.14%     
==========================================
  Files          64       65       +1     
  Lines        2955     2993      +38     
==========================================
  Hits          313      313              
- Misses       2639     2677      +38     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mamachanko mamachanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not studied every single line but LGTM! Thank you for sending that through.

@scothis scothis merged commit 8e5d072 into reconcilerio:main Jun 8, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting support for discovery/v1 CRDs
2 participants