Seal dies to enable diff and patch operations #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add tests and attempt to minimize new packages introduced. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
=========================================
+ Coverage 9.71% 10.78% +1.06%
=========================================
Files 69 74 +5
Lines 3221 3283 +62
=========================================
+ Hits 313 354 +41
- Misses 2905 2918 +13
- Partials 3 11 +8 ☔ View full report in Codecov by Sentry. |
|
@scothis shouldn't it be |
mamachanko
approved these changes
Jun 19, 2024
DieSeal stashes the current value of the die for later use in DieDiff and DiePatch operations. DieDiff use cmp.Diff to generate a textual diff of changes made to the die since it was seeled. DiePatch generates patch bytes to go from the sealed to current value. Note: diff and patch operations are only meaningful from the root die. Dies used while stamping do not contain the original sealed value. Individual patch implementation must be dynamically registered before use. For the known patch types, this can be done by importing the respective package. A meaningful error is provided if the type is not imported. Users may implement additional or alternative patch types. Signed-off-by: Scott Andrews <[email protected]>
scothis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DieSeal stashes the current value of the die for later use in DieDiff and DiePatch operations. DieDiff use cmp.Diff to generate a textual diff of changes made to the die since it was seeled. DiePatch generates patch bytes to go from the seeled to current value.