Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

fix: update module version to v2 #764

Merged
merged 3 commits into from
May 5, 2022

Conversation

kazimierzbudzyk
Copy link
Contributor

Fixes module versioning to allow aws-nuke to be used as library.

Ref: https://github.com/golang/go/wiki/Modules#releasing-modules-v2-or-higher

@Wojtek-ana
Copy link

I am curious about the progress of this pull request, need it for a project. Is there anything I can do to help?

@kazimierzbudzyk
Copy link
Contributor Author

@Wojtek-ana feel free to make any contributions! I didn't have much tractions with feedback on the issue or the PR, the state is basically as you see it here. I am unblocked by forking and vendroing that, but very much would like to switch back to upstream.

@svenwltr svenwltr merged commit f7337e5 into rebuy-de:main May 5, 2022
@svenwltr
Copy link
Member

svenwltr commented May 5, 2022

Hello. Merging this took a bit longer, because we had to discuss it internally.

Please be cautious when using aws-nuke as a library, because it is not built as a library and there are not guarantees for api stability at all.

@svenwltr svenwltr mentioned this pull request May 5, 2022
@tbuatois
Copy link

Nice work guys, have you an ETA on a new release with this PR ? We still cannot import aws-nuke as module since it needs a github release...
Thanks a lot

@gowtham570
Copy link

+1 Would like to know the ETA on new release for this changes to be able to use aws-nuke as a module. TIA

@gowtham570
Copy link

Thanks @svenwltr for releasing the latest version 2.19.0 with the above changes. I was able to import the aws-nuke as a module with the latest release.

jrsholly added a commit to Optum/aws-nuke that referenced this pull request Jan 20, 2023
* Add support for Athena WorkGroups and NamedQueries (rebuy-de#464)

* Upgrade to aws sdk version 1.28.12 (rebuy-de#466)

* Upgrade to aws sdk version 1.28.12

* added eks fargate profile resource (rebuy-de#469)

* added eks fargate profile resource

* added eks nodegroup as resource (rebuy-de#468)

* added eks nodegroup as resource

* add route53 health check resource (rebuy-de#471)

* Delete all record sets of the type "NS" except for the default "NS" settings (rebuy-de#473)

* fixed rrs behaviour on NS deletion

* Handle pagination 101+ route53 healthchecks (rebuy-de#472)

* Handle 101+ route53

* add cloudformation stackset support (rebuy-de#475)

* feat: Add OwnerId Prop to EC2TGW (rebuy-de#483)

* rebuy-de#430 - cloudformation support for disabling termination protection (rebuy-de#481)

* rebuy-de#430 - cloudformation support for disabling termination protection

* Disable Security Hub (rebuy-de#484)

* Disable Security Hub

See rebuy-de#452

Add the ability to detect regions with Security Hub enabled and disable it if a
"hub" resource is returned.

* Rename property of SecurityHub hub Arn

* Replace Regex in S3Object sample to recursive nuke (rebuy-de#486)

Replace the wildcard to ** to allow recurside sublevel directories in
the nuke process.

Co-authored-by: Bruno Paiuca <[email protected]>

* only list active stacksets; ignore deleted (rebuy-de#488)

* Additional tag support (rebuy-de#492)

* add tag support to ec2 security groups

* add tag support to iam roles

* add tag support to elastic ip addresses

* fix code alignment

Co-Authored-By: Philipp Trulson <[email protected]>

* Capitalise ID for consistency

Co-Authored-By: Sven Walter <[email protected]>

* go fmt changes

Co-authored-by: Philipp Trulson <[email protected]>
Co-authored-by: Sven Walter <[email protected]>

* Feature/324 date filter (rebuy-de#480)

* rebuy-de#324 - initial POC of filtering based on dates

* rebuy-de#324 - initial POC of filtering based on dates

* support additional date format

* update documentation to include date formats

* Updates based on PR feedback:
* change name to be more clear
* apply offset to field time, not current time, as it is easier to understand
* Update documentation to be more clear

* add tag support to additional resource types (rebuy-de#509)

* add tag support to acmpca
* add tag support to acm certificates
* add tag support to ssm parameters

* fix Route53HealthCheck loop (rebuy-de#510)

* Fix presets filter example in README (rebuy-de#514)

There was a typo, using `presets.common.filter` instead of `presets.common.filters` actually fails to parse.

* add firewall manager resources (rebuy-de#491)

* add firewall manager resources

* add support for Properties interface to firewall manager resources

* Use golang property style names

Co-authored-by: Björn Häuser <[email protected]>

* Add quay.io badge and note where to find releases (rebuy-de#519)

* Generate mocks before building (rebuy-de#499)

* Generate mocks before building

* Fix quay URL in readme

* add comprehend resources (rebuy-de#531)

* add cloudformation type support (rebuy-de#530)

* add support for programatically setting custom aws credentials (rebuy-de#529)

* add iam user SSH public key support (rebuy-de#533)

Co-authored-by: Tom Neyland <[email protected]>
Co-authored-by: Matt Shipman <[email protected]>

Co-authored-by: Tom Neyland <[email protected]>
Co-authored-by: Matt Shipman <[email protected]>
Co-authored-by: Joey Davenport <[email protected]>

* Added support for image builder resources (rebuy-de#535)

* added image builder support

* oops, figured out difference between image version and image build version, same for component

* added global accelerator resources (rebuy-de#524)

* added global accelerator resources

* Update resources/ga-listeners.go

Co-authored-by: Björn Häuser <[email protected]>

* Update resources/ga-endpoints.go

Co-authored-by: Björn Häuser <[email protected]>

* Update resources/ga-accelerators.go

Co-authored-by: Björn Häuser <[email protected]>

* refactoring type names

Co-authored-by: Björn Häuser <[email protected]>

* Add API Gateway v2 APIs as a resource (rebuy-de#538)

* Add API Gateway v2 VPC links & properties for some resources (rebuy-de#540)

* Add properties to old API GW resources

* Add API Gateway v2 VPC Link resource

* Use Go 1.15 & update dependencies (rebuy-de#539)

* Add wafregional rulegroup & properties for some resources (rebuy-de#541)

* Add WAF regional rulegroup resource

* Add properties to wafregional resources

* Add support for CloudWatchLogsResourcePolicy (rebuy-de#521)

* add support for CloudWatchLogsResourcePolicy

* add Properties()

* remove anonymous feature flag struct (rebuy-de#527)

anonymous structs require one to specify the whole struct signature when
setting the flags

* Add WAFv2 resources (rebuy-de#542)

* Add tags for KMS keys (rebuy-de#544)

* Add properties for KMS aliases

* Add tags to KMS keys

* Add RDS Event Subscriptions resource (rebuy-de#543)

* Add Path property to IAM roles for filtering (rebuy-de#545)

* Add AWS Lex resources (rebuy-de#546)

* Enable paging for KMS Keys (rebuy-de#549)

* kms-key: Skip aws managed keys (rebuy-de#550)

* kms-keys: Skip keys already in pending deletion state (rebuy-de#551)

* Build binaries for Windows & ARM (rebuy-de#548)

* Enable CLICOLOR and CLICOLOR_FORCE env variables (rebuy-de#557)

* Adding some more route53 resources (rebuy-de#556)

* feat: adding route53 resolver resource

Co-authored-by: Tom Neyland <[email protected]>
Co-authored-by: Max Krieg <[email protected]>

* feat: adding route53 traffic policies

Co-authored-by: Ryan Swanson <[email protected]>
Co-authored-by: Russell Centanni <[email protected]>

* fix: fixing traffic policy and instance deletion

* Code review changes and NextToken checks (rebuy-de#508)

* Removed unused types
* Renamed resources to singular form
* Updated return values
* Updated loops to keep going until NextToken is nil

* Code review change spelling fix (rebuy-de#508)

* Moving passed
 • roles that can be listed, but not retrieved.
 • role policies that that fail to list.

Co-authored-by: Tom Neyland <[email protected]>
Co-authored-by: Max Krieg <[email protected]>
Co-authored-by: Tom Neyland <[email protected]>
Co-authored-by: Russell Centanni <[email protected]>

* Add Transfer Server & User resources (rebuy-de#562)

* Add CodeStar Notification Rules resource (rebuy-de#563)

* Add CodeStar Notification Rules resource

* Force removal of cloudwatch event target

* Lambda functions pages (rebuy-de#575)

* added properties to ec2 network ACL

* can scan/delete > 50 lf with ListFunctionsPages

* Add EC2EgressOnlyInternetGateway resource (rebuy-de#576)

* Add support for deleting cache parameter groups (rebuy-de#577)

* Add support for deleting cache parameter groups

* Add Properties method

* Add filter for default cache parameter groups

* added lambda layers resource (rebuy-de#579)

* added lambda layers resource

* updated after feedback

* removed comment

* NS-2448: Added resource for CloudFront OAI (rebuy-de#478)

Co-authored-by: Joe Chung <[email protected]>

* Migrate to GitHub actions (rebuy-de#587)

* Migrate to GitHub actions

* Install golint

* Don't fetch all tags for normal builds

* Build zips for Windows

* Build & upload release assets

* Remove travis

* Add job names

* Allow to nuke Cognito's Identity Providers (rebuy-de#588)

* Allow to nuke Cognito's Identity Providers

* Add extra properties

* Fix GitHub Actions syntax in release pipeline (rebuy-de#589)

* updte SNS with properties and pages (rebuy-de#592)

* added pagination and properties to iampolicy (rebuy-de#593)

* added pagination and properties to iampolicy

* updte SNS with properties and pages (rebuy-de#592)

* added pagination and properties to iampolicy

* use blocklist over blacklist (rebuy-de#595)

* use blocklist over blacklist

* support old config key but encourage users to upgrade

* add test to ensure support for the deprecated key

* Added tag based filter for Secrets Manager Secret and RDS Instance (rebuy-de#585)

* Siddharth | Add tag in rds properties

* Siddharth | Enable tag based filter in secretmanager

* Siddharth | Fixed formatting

* Siddharth | fixed tag properties set

* Nuke Cognito user pool clients (aka. "App clients") (rebuy-de#590)

* Adapt Readme & CI for main branch (rebuy-de#596)

* Add properties & feature flag for lightsail (rebuy-de#597)

* Add properties to servicecatalog resources (rebuy-de#598)

* Use Go 1.16, update deps & build Apple M1 binaries (rebuy-de#602)

* Use Go 1.16 for builds

* Update dependencies

* Build binaries for Apple M1 devices

* Build multiarch docker images (rebuy-de#604)

* Build multiarch docker images

* Build tags too

* Add properties for IAM role and group attachments (rebuy-de#614) (rebuy-de#615)

Co-authored-by: Antoine C <[email protected]>

* remove armv7 (rebuy-de#618)

* Fix PR builds (rebuy-de#619)

* remove armv7

* fix PR builds

* network-interfaces: detach eni before deleting (rebuy-de#607)

Network Interfaces (ENIs) can remain attached to an instance even
after the associated instance has been destroyed. ENIs in an attached
state cannot be deleted directly. They must first be detached. This
commit detaches the ENI, if attached, then proceeds with deletion.

* Use `uname -n` to get the machine's hostname (rebuy-de#609)

`shell echo $$HOSTNAME` was expanding to nothing.

* Ignore errors when deleting Service Catalog Provisioned Products. (rebuy-de#608)

I have run into an issue where aws-nuke will successfully delete the
cloudformation stacks created by the service catalog but then fails to
delete the service catalog as it is not able to find the cloudformation
stacks to delete. I think adding the ignore errors flag will make
aws-nuke more robust.

* add some logging for cloudformation stacks with termination protection (rebuy-de#528)

* feat: adding support for nuking aws appsync graphql api resource (rebuy-de#617)

* feat: adding support for nuking aws appsync graphql api resource

This commit adds support for nuking AWS AppSync GraphQL APIs. The resource type is AppSyncGraphqlApi (following AWS SDK naming and casing). It supports filtering by API name and tags.

* fix: correcting casing

This commit corrects casing of structurs and functions to adhere to golang recommendations. This updates the configurable resource-type to "AppSyncGraphqlAPI".

* fix: adding apiid to properties to supporting filtering

Adding the AppSync API ID to the resource properties to support filtering by APIID.

Co-authored-by: Joshua Hornsby <[email protected]>

* Add SageMaker studio resources (rebuy-de#612)

* Add SageMaker studio resources

* Add properties function to SageMakerDomain

* Add filter to SageMakerApp

* Rename domainId -> domainID

* App auto scaling scalable targets (rebuy-de#621)

* Added ScalableTargets resource with namespace lookup

* Fixed formatting

* Added ScalableTargets resource with namespace lookup

* Fixed formatting

* Misspelled Dimension

* Add AppMesh resources (rebuy-de#624)

* added AppMesh resources

Added Mesh, Route, VirtualGateway, VirtualNode,
VirtualRouter and VirtualService AppMesh resources.

* Updated name property for AppMesh resources

* add Sagemaker NotebookInstanceLifecycleConfigs (rebuy-de#558)

* add Sagemaker NotebookInstanceLifecycleConfigs

https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_ListNotebookInstanceLifecycleConfigs.html

* add properties

* shorten property name

* Update resources/sagemaker-notebookinstancelifecycleconfigs.go

Co-authored-by: Sven Walter <[email protected]>

* Add CodeStar Connections (rebuy-de#620)

* Add AWS CodeStar Connections

* Update resources/codestar-connections.go

Co-authored-by: Björn Häuser <[email protected]>

* Rename other occurrences of connectionArn

Co-authored-by: Björn Häuser <[email protected]>

* Minor Readme changes (rebuy-de#628)

* Use paginated API for listing Security groups, ASGs, ELBs, and launch configrations (rebuy-de#632)

* Add GuardDuty detectors (rebuy-de#625)

* Add GuardDuty detectors

* Include review suggestions

* add X-Ray resources (rebuy-de#638)

support for sampling rules & groups.

* Added Amazon Managed Service for Prometheus support (rebuy-de#639)

* feat: add tags to Route53HostedZone (rebuy-de#642)

* Handle undeletable Backup Vault from EFS Automatic Backups (rebuy-de#643)

* Do not attempt to delete aws/efs/automatic-backup-vault and related plans from EFS Automatic Backups

https://aws.amazon.com/premiumsupport/knowledge-center/efs-disable-automatic-backups/#:~:text=Note%3A%20You,automatic-backup-vault

* Remove Backup Vault Access Policies to permit Vault deletion

For example, the default "aws/efs/automatic-backup-vault" vault created when EFS backups are enabled has a policy that denies deletion. The policy is set to Allow and then the policy can be deleted.

https://aws.amazon.com/premiumsupport/knowledge-center/efs-disable-automatic-backups/

* Ignore error from if we can't put permissive backup vault policy in for some reason, that's OK.
In the end, deletion is the only call we actually really care about for err.

* chore: update aws-sdk-go dep (rebuy-de#644)

* Fix typo in cloudformation-stack.go (rebuy-de#645)

* Add RDS Option Groups Support (rebuy-de#646)

Closes rebuy-de#637

Pretty much a copy and paste renaming of db parameter groups.

* Only build docker images on our own PRs (rebuy-de#657)

* Enable us-gov-cloud by setting the default partition correctly (rebuy-de#647)

* Add tag based filtering for codebuild projects (rebuy-de#648)

* Add tag based filtering for codebuild projects

* Check for non-tagged codebuild projects

* Added space b/w statements

* Update resources/codebuild-projects.go

Co-authored-by: Sven Walter <[email protected]>

* Add MSKConfiguration resource (rebuy-de#649)

* fix comprehend entities detection job deletion (rebuy-de#653)

* Add support for Access Analyzer resources (rebuy-de#659)

Two new resources:
- Analyzer
- Archive Rules

Co-authored-by: achatain <[email protected]>

Co-authored-by: achatain <[email protected]>

* [WIP] Add tags to IAM resources (rebuy-de#662)

* add function to call get role and policy apis

* fetch iam role and policy when listing resources

* extract iam role and policy tags into properties

* Add ability to assume a role before nuking (rebuy-de#667)

* add assume-role-arn flag to cli arguments and credentials struct

* assume role provided if present

* Add RDS proxy deletion support (rebuy-de#669)

* Add RDS proxy deletion support

* Update resources/rds-proxies.go

Co-authored-by: Sven Walter <[email protected]>

Co-authored-by: Sven Walter <[email protected]>

* Add important EC2 metadata to instance properties (rebuy-de#670)

In order to power filtering of EC2 instances via common properties, this
commit adds instance identifier, image identifier, instance state,
instance type, and instance launch time to the properties for EC2
resources.

This allows (for example):
- pruning instances launched from a specific AMI.
- pruning instances launched a given duration ago.
- pruning instances that are stopped.
- pruning instances of a given type.

* Update dependency `aws-sdk-go` v1.38.42 -> v1.40.39 (rebuy-de#677)

Direct upgrade of `aws-sdk-go` from v1.38.42 -> v1.40.39. Aiming to
update as the dependency is a bit out-of-date, and I'm looking to use
functionality that is only provided in newer versions of the library.

* Add support for nuking CodeArtifact resources (rebuy-de#689)

* support codeartifact domains and repositories

* include domain details for codeartifact repository

* advertise association with default vpc through properties (rebuy-de#691)

* advertise association with default vpc through properties

* rename property and adopt naming convention

* Add `CreationTime` and `LastUpdatedTime` to cloudformation stacks (rebuy-de#676)

Add the ability to easily filter for old/expired cloudformation stacks
by adding `CreationTime` and `LastUpdatedTime` properties to each
cloudformation stack.

* add IAM signing certificate resource (rebuy-de#695)

* Add `InstanceCreateTime` to RDS instances (rebuy-de#679)

Add the ability to easily filter for old/expired RDS instances by adding
`InstanceCreateTime` properties to each RDS instance.

* Add `CreatedAt` property to EKS nodegroups (rebuy-de#680)

Add the ability to easily filter for old or expired EKS nodegroups by adding
the `CreatedAt` property to them. This allows `aws-nuke` to easily clear out
all "old" resources while leaving recent ones intact.

* fixup! Merge branch 'main' of rebuy/nuke into add_budgets (rebuy-de#650)

* Add properties to apigw usage rebuy-de#402 (rebuy-de#685)

* default vpc filter for dhcp option (rebuy-de#694)

Co-authored-by: Sven Walter <[email protected]>

* Ignore failed entities and sentiments jobs (rebuy-de#696)

Co-authored-by: student <[email protected]>

* Add installation example (rebuy-de#697)

* init

* denote section

* fix: remove predicates before rule delete (rebuy-de#704)

Co-authored-by: curtis <[email protected]>

* New resource S3AccessPoint (rebuy-de#710)

* feat: Add resource S3AccessPoint

* fix: Lookup correct s3-control endpoint id vs service name

* adding support for inspector runs, targets, templates (rebuy-de#712)

* Added new resource for KendraIndex (rebuy-de#718)

* Added new resource for LexModelBuildingServiceBotAlias (rebuy-de#719)

* Ignore inaccessible policies (rebuy-de#722)

In some AWS organizations polices may be inaccessible to the person
running aws-nuke. Log the erros and continue.

* Add String() and handle expected errors from the detach (rebuy-de#720)

* Add ec2 snapshot starttime (rebuy-de#725)

* adding ability to nuke macie (rebuy-de#729)

* Add tag outputs for the EFSFileSystem, EKSCluster, EKSNodegroup and ESDomain resources (rebuy-de#727)

* add property for EKSCluster tags

* add property for ESDomain tags

* fix property for ESDomain tags

* add property for EFS tags

* add property for Nodegroup tags

* fix property for Nodegroup tags

* fix merge conflict for eks-nodegroups

Co-authored-by: y509319 <y509319>

* Add resource for default security group rules (rebuy-de#721)

* Disable GlobalAccelerator before deleting it (rebuy-de#723)

* feat: add missing tags for iam resources (rebuy-de#731)

* feat: add tags for iam user

* fix: propagate tags for iam user

* chore(iam-role-policy): reorder imports

* feat(iam-instance-profile): add tags

* feat: support new resource ec2 host (rebuy-de#736)

Co-authored-by: Xin Chen <[email protected]>

* Add tags and properties to some resources (rebuy-de#734)

* feat: add tags for autoscaling-groups

* feat: add tags for ec2 resources

* feat: add name and creationDate property to ec2-image

* feat: add ownerID property for ec2 resources

This is usefull for shared resources

* feat: add name and ID property to efs-mount-target

* feat: add name, path and id property to iam-group

* feat: add role, profile and tags property to iam-instance-profile-role

* feat: add groupName and userName property to iam-instance-profile-role

* feat: add userName, accessKeyID and tags property to iam-user-access-key

* feat: Update InstanceProfile and InstanceProfileRole output properties (rebuy-de#739)

* Update InstanceProfile and InstanceProfileRole properties

* Apply suggested changes

* oops, deleted unnecessary function

* Build with Go 1.17 & update dependencies (rebuy-de#740)

* instanceprofilerolebug (rebuy-de#741)

* Remove armv7 builds (rebuy-de#742)

* feat(cloudwatch-alarms): add name property (rebuy-de#746)

* fix(EC2NetworkInterface): fix panic on not attached NetworkInterfaces 🐛 (rebuy-de#752)

It is possible, that an interface is not attached. This leads to the fact that no AttachmendId is available. Accordingly, the string can also not be accessed.

* Add tag support for IAMUser and IAMUserPolicyAtt (rebuy-de#762)

The tag support that was added for IAMUser wasn't working as it
was relying on the tags coming back via the UserList API. AWS
documnents that while the response includes a list of tags, it
isn't populated. Fixed this issue by calling GetUser to retrieve
the tags.

Added support for tags to IAMUserPolicyAttachments that mimics the
functionality present in IAMRolePolicyAttachments.

* fix: exclude nested cloudformation stacks (rebuy-de#761)

* add support for cloud control (rebuy-de#753)

* add support for cloud control

* delete cloud control resources

* show list capabilities for cloud control

* add more cloud control resources

* handle cloud control properties

* add cloud control documentation

* disable AWS::Athena::DataCatalog (rebuy-de#768)

* fix: default security group deletion, should not proceed if groupIds is 0 (rebuy-de#766)

* Feature 771 S3 CreationDate property (rebuy-de#772)

* Add CreationDate property
Add CreationDate to properties so that S3 can be filtered based on when the resource was created.

* correct syntax
add . to the end of previous line to follow existing syntax.

* correct syntax
remove unnecessary brackets

* fix linting errors (rebuy-de#774)

* fix s3 buckets (rebuy-de#773)

* add AWS::NetworkFirewall (rebuy-de#777)

* Inspector2 Support (rebuy-de#781)

* fix go files

* add support for disabling inspector2

* add accountid as property

* fix: import/reference

* fix: go.mod require statements

* fix: update module version to v2 (rebuy-de#764)

* fix build (rebuy-de#790)

* Build with Go 1.18 & update dependencies (rebuy-de#792)

* Build with Go 1.18 & update dependencies

* Fix package name

* Add RDSClusterSnapshot and CloudTrailTrail Name (rebuy-de#793)

* feat(CloudTrailTrail): add property name ✨

* feat(RDSClusterSnapshot): add resource ✨

This is nearly an 1:1 copy from RDSSnapshot

* Adds log line for previously ignored GetProperty err value. (rebuy-de#770)

* Adds log line for previously ignored GetProperty err value.

* Adds continue as there is no point in matching a filter to a property that doesn't exist

* Update cmd/nuke.go

Co-authored-by: Sven Walter <[email protected]>

Co-authored-by: Sven Walter <[email protected]>

* Build release binary with Go 1.18 (rebuy-de#799)

* add go version to version command (rebuy-de#800)

* Support deletion of CostandUsageReports resources (rebuy-de#804)

Co-authored-by: Nikolay Efimov <[email protected]>

* Remove deprecated resources (rebuy-de#809)

* add tag property for EFSMountTarget (rebuy-de#815)

* add property for EKSCluster tags

* add property for ESDomain tags

* fix property for ESDomain tags

* add property for EFS tags

* add property for Nodegroup tags

* fix property for Nodegroup tags

* fix merge conflict for eks-nodegroups

* add property for EFSMountTarget tags

Co-authored-by: y509319 <y509319>

* Allows filtering of ASGs based on creation time (rebuy-de#769)

* Adds date format specific to what is provided by ASG resource.
Adds property to ASG resource to allow filtering based on creation time.

* Corrects ordering

Co-authored-by: Sven Walter <[email protected]>

* Remove unused type NukeParameters in main.go (rebuy-de#822)

This was probably succeeded by the one in cmd/params.go

* improvement: New resource EC2VPCEndpointConnection (rebuy-de#823)

* improvement: New resource EC2VPCEndpointConnection

* register owner

* fix: Correctly filter policy attachments in aws-us-gov (rebuy-de#821)

* fix: Correctly filter policy attachments in aws-us-gov

* fmt

* Only force sleep to be more than 3 seconds if `--no-dry-run` is set (rebuy-de#835)

Useful for debugging discovery/listing. Allows setting it to 0 if the nuking isn't going to be happen.

* Improve eventbridge resource cleanup (rebuy-de#836)

* delete targets, rules for any bus. delete custom buses.

* Remove prefix 'Bus:' from name

* added DisableDeletionProtection Flag for ELBv2 (rebuy-de#839)

Co-authored-by: Patrick Magyar <[email protected]>

* Use kinesisanalyticsv2 to resolve: ERRO[0094] UnsupportedOperationException: xxxxxx was created/updated by kinesisanalyticsv2 SDK. Please use kinesisanalyticsv2 SDK to make changes to xxxxxx. (rebuy-de#687)

* Build with Go 1.19 & update dependencies (rebuy-de#843)

* Build with Go 1.19 & update dependencies

* Update GitHub Actions workflows

* Handle pagination for IoTCertificates (rebuy-de#844)

Closes rebuy-de#831

* Update deps & add dependabot config (rebuy-de#852)

* add tag support to CloudWatchLogsLogGroup (rebuy-de#855)

* Bump github.com/aws/aws-sdk-go from 1.44.104 to 1.44.109 (rebuy-de#857)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.104 to 1.44.109.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.104...v1.44.109)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix tag name for dependabot PRs (rebuy-de#861)

* Bump github.com/aws/aws-sdk-go from 1.44.109 to 1.44.114 (rebuy-de#860)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.109 to 1.44.114.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.109...v1.44.114)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add support for managed grafana (rebuy-de#859)

* add support for QLDB ledgers (rebuy-de#841)

* Bump github.com/aws/aws-sdk-go from 1.44.114 to 1.44.121 (rebuy-de#867)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.114 to 1.44.121.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.114...v1.44.121)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/stretchr/testify from 1.8.0 to 1.8.1 (rebuy-de#868)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.0...v1.8.1)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 (rebuy-de#865)

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.5.0...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Schedule dependabot PRs on Tuesdays (rebuy-de#869)

> This is an automatically generated PR.

@rebuy-de/prp-aws-nuke @rebuy-de/ Please review.

* Bump github.com/spf13/cobra from 1.6.0 to 1.6.1 (rebuy-de#871)

* Bump github.com/aws/aws-sdk-go from 1.44.121 to 1.44.122 (rebuy-de#870)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.121 to 1.44.122.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.121...v1.44.122)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go from 1.44.122 to 1.44.127 (rebuy-de#872)

* Bump github.com/aws/aws-sdk-go from 1.44.127 to 1.44.132 (rebuy-de#875)

* Add tag filtering to OpenID connect provider (rebuy-de#878)

Added ability to filter on the tags of the OpenID connect provider

* Bump github.com/aws/aws-sdk-go from 1.44.132 to 1.44.137 (rebuy-de#881)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.132 to 1.44.137.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.132...v1.44.137)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go from 1.44.137 to 1.44.143 (rebuy-de#885)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.137 to 1.44.143.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.137...v1.44.143)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go from 1.44.143 to 1.44.147 (rebuy-de#886)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.143 to 1.44.147.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.143...v1.44.147)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go from 1.44.147 to 1.44.153 (rebuy-de#888)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.147 to 1.44.153.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.147...v1.44.153)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add CreateDate and LastUsedDate for IAMRole resource (rebuy-de#887)

* Return "Unnamed job" for null-valued Comprehend analysis job names for logging purposes (rebuy-de#884)

This fixes issue rebuy-de#883.

Co-authored-by: James Park <[email protected]>

* Use yaml.v3 & rebuy Go SDK v4 (rebuy-de#890)

* Use yaml.v3 for config

* Upgrade rebuy Go SDK

* Update versions on release (rebuy-de#891)

* Fix readme update job (rebuy-de#892)

* Fix readme update job again (rebuy-de#893)

* Bump github.com/aws/aws-sdk-go from 1.44.153 to 1.44.163 (rebuy-de#899)

* Bump github.com/aws/aws-sdk-go from 1.44.163 to 1.44.171 (rebuy-de#908)

* feat: add opensearch domains (rebuy-de#910)

* feat: add IsLoadBalanced property for elbv2 target groups (rebuy-de#906)

* Add tag filtering for cloudwatch alarms (rebuy-de#900)

* Add tag filtering for cloudwatch alarms

* Caught errors from the cloudwatch 'get tags for resource' api call

* Bump github.com/aws/aws-sdk-go from 1.44.171 to 1.44.176 (rebuy-de#915)

* Fix route53 hosted zone pagination issue (rebuy-de#916)

* add AppMesh virtual gateway route resource (rebuy-de#912)

Co-authored-by: oliver.rose <[email protected]>

* Add gluedatabrew (rebuy-de#917)

* feat(iam-role): add properties to policies and instance profile) (rebuy-de#914)

* Add properties on multiple resources (rebuy-de#911)

* feat(elbs): add CreatedTime property

* feat(RDS): add CreatedTime property

* feat(Redshift): add CreatedTime and tags properties

* fix(s3 buckets): fix CreationDate property

* feat(EMR): add CreatedTime property

* feat(ECR): add tags and CreatedTime properties

* feat(CloudwatchLogGroup): add CreatedTime and LastEvent properties

* feat(CloudFrontDistribution): add tags and LastModifiedTime properties

* Bump github.com/rebuy-de/rebuy-go-sdk/v4 from 4.1.0 to 4.2.0 (rebuy-de#918)

Bumps [github.com/rebuy-de/rebuy-go-sdk/v4](https://github.com/rebuy-de/rebuy-go-sdk) from 4.1.0 to 4.2.0.
- [Release notes](https://github.com/rebuy-de/rebuy-go-sdk/releases)
- [Commits](rebuy-de/rebuy-go-sdk@v4.1.0...v4.2.0)

---
updated-dependencies:
- dependency-name: github.com/rebuy-de/rebuy-go-sdk/v4
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github.com/aws/aws-sdk-go from 1.44.176 to 1.44.180 (rebuy-de#919)

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.44.176 to 1.44.180.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.44.176...v1.44.180)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix nil pointer deref for instance profiles (rebuy-de#920)

* Update md files, gitignore, and add mocks with latest rebuy-de/aws-nuke

* Add .travis.yml file back

* Removed unneeded workflow files. Updated codeowners

* Fix codeowners

* Replicate what was in generate_mocks before syncing fork

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Edan Schwartz <[email protected]>
Co-authored-by: Jan Michalowsky <[email protected]>
Co-authored-by: matthagenbuch <[email protected]>
Co-authored-by: Brian <[email protected]>
Co-authored-by: Tyler Southwick <[email protected]>
Co-authored-by: Ryan Whelan <[email protected]>
Co-authored-by: Jeff <[email protected]>
Co-authored-by: Greg Bailey <[email protected]>
Co-authored-by: Bruno Paiuca <[email protected]>
Co-authored-by: Bruno Paiuca <[email protected]>
Co-authored-by: Stephen Palfreyman <[email protected]>
Co-authored-by: Philipp Trulson <[email protected]>
Co-authored-by: Sven Walter <[email protected]>
Co-authored-by: Sven Walter <[email protected]>
Co-authored-by: Zoltán Reegn <[email protected]>
Co-authored-by: Björn Häuser <[email protected]>
Co-authored-by: Ryan Swanson <[email protected]>
Co-authored-by: Tom Neyland <[email protected]>
Co-authored-by: Matt Shipman <[email protected]>
Co-authored-by: Joey Davenport <[email protected]>
Co-authored-by: Bill Schneider <[email protected]>
Co-authored-by: Oliver Schönherr <[email protected]>
Co-authored-by: Haitao Li <[email protected]>
Co-authored-by: Ilia Choly <[email protected]>
Co-authored-by: Max Krieg <[email protected]>
Co-authored-by: Tom Neyland <[email protected]>
Co-authored-by: Russell Centanni <[email protected]>
Co-authored-by: Ken Keller <[email protected]>
Co-authored-by: Kevin Scholz <[email protected]>
Co-authored-by: Kurt McAlpine <[email protected]>
Co-authored-by: Joe <[email protected]>
Co-authored-by: Joe Chung <[email protected]>
Co-authored-by: Jonathan Ballet <[email protected]>
Co-authored-by: Daniel Freudenberger <[email protected]>
Co-authored-by: Siddharth Shashikar <[email protected]>
Co-authored-by: Jonathan Ballet <[email protected]>
Co-authored-by: Antoine Colombier <[email protected]>
Co-authored-by: Antoine C <[email protected]>
Co-authored-by: carloruiz <[email protected]>
Co-authored-by: Gianluca Recchia <[email protected]>
Co-authored-by: jdhornsby <[email protected]>
Co-authored-by: Joshua Hornsby <[email protected]>
Co-authored-by: Travis Smith <[email protected]>
Co-authored-by: Andreas Skarmutsos Lindh <[email protected]>
Co-authored-by: Troy Ready <[email protected]>
Co-authored-by: adamstirk-ct <[email protected]>
Co-authored-by: Hunter Morris <[email protected]>
Co-authored-by: Caleb Lemoine <[email protected]>
Co-authored-by: Nelson Chen <[email protected]>
Co-authored-by: Matthew Dennison <[email protected]>
Co-authored-by: Chris Gilmer <[email protected]>
Co-authored-by: Siddharth Shashikar <[email protected]>
Co-authored-by: Steve Teuber <[email protected]>
Co-authored-by: Vlastimil Zeman <[email protected]>
Co-authored-by: achatain <[email protected]>
Co-authored-by: Nicolas Trettel <[email protected]>
Co-authored-by: Elay Gliksberg <[email protected]>
Co-authored-by: Remi Broemeling <[email protected]>
Co-authored-by: Paul T <[email protected]>
Co-authored-by: rburchill <[email protected]>
Co-authored-by: student <[email protected]>
Co-authored-by: Rida Ayed <[email protected]>
Co-authored-by: Curtis <[email protected]>
Co-authored-by: curtis <[email protected]>
Co-authored-by: Erik Kristensen <[email protected]>
Co-authored-by: Peter McNeill <[email protected]>
Co-authored-by: Michael Mayer <[email protected]>
Co-authored-by: ChaseFreeman17 <[email protected]>
Co-authored-by: y509319 <[email protected]>
Co-authored-by: Manuel Vogel <[email protected]>
Co-authored-by: Xin Chen <[email protected]>
Co-authored-by: Xin Chen <[email protected]>
Co-authored-by: hv202x1 <[email protected]>
Co-authored-by: Stoimen Hristov <[email protected]>
Co-authored-by: Doug Shelley <[email protected]>
Co-authored-by: James Geddes <[email protected]>
Co-authored-by: kazimierzbudzyk <[email protected]>
Co-authored-by: Lewis Edginton <[email protected]>
Co-authored-by: Nikolai Efimov <[email protected]>
Co-authored-by: Nikolay Efimov <[email protected]>
Co-authored-by: Alex <[email protected]>
Co-authored-by: pmagyar <[email protected]>
Co-authored-by: Patrick Magyar <[email protected]>
Co-authored-by: Claudio Catterina <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Avritt Rohwer <[email protected]>
Co-authored-by: Jan Vanbuel <[email protected]>
Co-authored-by: leighpascoe <[email protected]>
Co-authored-by: Ivan Morgun <[email protected]>
Co-authored-by: James Park <[email protected]>
Co-authored-by: James Park <[email protected]>
Co-authored-by: Thomas Lambert <[email protected]>
Co-authored-by: Craig Bryan <[email protected]>
Co-authored-by: sschwebler <[email protected]>
Co-authored-by: Oliver Rose <[email protected]>
Co-authored-by: oliver.rose <[email protected]>
Co-authored-by: YOON <[email protected]>
Co-authored-by: Thomas Lambert <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants