Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL #806

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

GraphQL #806

wants to merge 1 commit into from

Conversation

SanderSpies
Copy link
Contributor

WORK IN PROGRESS.

This is just syntax for now - it doesn't work or anything.

I would love to get feedback on this already before I continue with implementing the other details.

@kayceesrk
Copy link
Contributor

A general question about such language extensions is whether they should be part of the core language syntax or ppx syntax extensions. Is there something in the proposed extension that would make it tedious to describe them as a ppx extension. Wondering if you had any thoughts on this?

@SanderSpies
Copy link
Contributor Author

SanderSpies commented Oct 17, 2016

@kayceesrk I share your concerns, and I'm not sure if this is the right idea. So far I'm leaning more towards staying close to the actual GraphQL query syntax (but still giving us the freedom to improve where possible).

PPX is definitely an interesting option though:

let%query example = {
  hero: {
    name: string
  },
  droid: {
    name: string
  }
};

Although I'm not sure how we would add support for fragments here.

@kennetpostigo
Copy link
Contributor

@SanderSpies this is something that I mentioned here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants