Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to cram suite #2694

Merged
merged 83 commits into from
Mar 20, 2023

Conversation

davesnx
Copy link
Member

@davesnx davesnx commented Mar 6, 2023

What's this PR

  • Migrate all test to cram
  • Moved testOprint inside refmt_test folder, and rename it to typedtree_printer
  • Used refmt as a binary in all cram tests (instead of hardcoded path to refmt_impl.exe)

Next

I will push a few PRs with:

  • Remove the old test suite from both Makefile and CI

@davesnx davesnx force-pushed the Migrate-format-type-tests-to-cram branch from df7dcb2 to 4086593 Compare March 6, 2023 22:57
@davesnx davesnx force-pushed the Migrate-format-type-tests-to-cram branch 2 times, most recently from 989d6dc to 43f0026 Compare March 7, 2023 10:37
@davesnx davesnx force-pushed the Migrate-format-type-tests-to-cram branch from 43f0026 to 5b48f33 Compare March 7, 2023 10:47
@davesnx davesnx force-pushed the Migrate-format-type-tests-to-cram branch from 4ab8f56 to 8a755ad Compare March 7, 2023 15:16
@davesnx davesnx changed the title Migrate each kind of tests from repo into cram suite Migrate tests to cram suite Mar 18, 2023
@davesnx davesnx merged commit 0ce98e0 into reasonml:master Mar 20, 2023
SanderSpies added a commit to SanderSpies/reason that referenced this pull request Apr 18, 2023
* master: (38 commits)
  chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710)
  Improve printing of modules types with one line inside (reasonml#2709)
  generate opam files with dune (reasonml#2704)
  Fix version on refmt (reasonml#2701)
  Drop the result dependency (reasonml#2703)
  Remove old CI and test.sh (reasonml#2705)
  Migrate tests to cram suite (reasonml#2694)
  Make sure win doesnt break when importing (reasonml#2700)
  Fix top level extensions (reasonml#2693)
  Install before importing deps
  Update package json and install esy normally
  Re-arrange esy install
  Reduce install esy time
  Use master branch instead of main
  Ignore _export from esy
  Rename refmt_test to test
  Add esy-ci and opam-ci
  Remove jbuild-ignore
  chore: update nix flake (reasonml#2692)
  chore(readme): clarify 3.9 is unreleased
  ...
SanderSpies added a commit to SanderSpies/reason that referenced this pull request Apr 18, 2023
* master: (38 commits)
  chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710)
  Improve printing of modules types with one line inside (reasonml#2709)
  generate opam files with dune (reasonml#2704)
  Fix version on refmt (reasonml#2701)
  Drop the result dependency (reasonml#2703)
  Remove old CI and test.sh (reasonml#2705)
  Migrate tests to cram suite (reasonml#2694)
  Make sure win doesnt break when importing (reasonml#2700)
  Fix top level extensions (reasonml#2693)
  Install before importing deps
  Update package json and install esy normally
  Re-arrange esy install
  Reduce install esy time
  Use master branch instead of main
  Ignore _export from esy
  Rename refmt_test to test
  Add esy-ci and opam-ci
  Remove jbuild-ignore
  chore: update nix flake (reasonml#2692)
  chore(readme): clarify 3.9 is unreleased
  ...
SanderSpies added a commit to SanderSpies/reason that referenced this pull request May 4, 2023
* master:
  fix: binary parser (reasonml#2713)
  Improve functor printing. (reasonml#2683)
  chore: remove old BS_NO_COMPILER_PATCH flag (reasonml#2710)
  Improve printing of modules types with one line inside (reasonml#2709)
  generate opam files with dune (reasonml#2704)
  Fix version on refmt (reasonml#2701)
  Drop the result dependency (reasonml#2703)
  Remove old CI and test.sh (reasonml#2705)
  Migrate tests to cram suite (reasonml#2694)
  Make sure win doesnt break when importing (reasonml#2700)
  Fix top level extensions (reasonml#2693)
  Install before importing deps
  Update package json and install esy normally
  Re-arrange esy install
  Reduce install esy time
  Use master branch instead of main
  Ignore _export from esy
  Rename refmt_test to test
  Add esy-ci and opam-ci
  Remove jbuild-ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants