Update bspack workflow for distributing BS6 compatible artifacts #2495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a way to easily distribute bspacked
reason_api.ml
andreason_binary.ml
files for BuckleScript v6 and above (4.06), mostly because we want to keep the Reason JS playground bundle up to date with most recent Reason releases.This PR keeps the original workflow alive (with slight adaptions in the README), but marks it as a legacy build workflow (BuckleScript will not support 4.02 in the future). Right now the 4.02 bspack instructions fail, mostly due to breaking updates to Reason, but it's still good to keep everything around for now.
The new workflow is introduced as
bspacks/reason_bspack406.sh
script, which needsBSPACK_EXE
to be defined (pointing to a locally built bspack for now). Example usage calls can be found in the script comments.Also, the 406 script takes the version from the
reason.json
file (since it looks like the source of truth for Reason version numbers). Easier for the user to not make mistakes.Any feedback would be valuable.
@thangngoc89