Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bspack workflow for distributing BS6 compatible artifacts #2495

Merged
merged 7 commits into from
Dec 1, 2019

Conversation

ryyppy
Copy link
Contributor

@ryyppy ryyppy commented Nov 19, 2019

We need a way to easily distribute bspacked reason_api.ml and reason_binary.ml files for BuckleScript v6 and above (4.06), mostly because we want to keep the Reason JS playground bundle up to date with most recent Reason releases.

This PR keeps the original workflow alive (with slight adaptions in the README), but marks it as a legacy build workflow (BuckleScript will not support 4.02 in the future). Right now the 4.02 bspack instructions fail, mostly due to breaking updates to Reason, but it's still good to keep everything around for now.

The new workflow is introduced as bspacks/reason_bspack406.sh script, which needs BSPACK_EXE to be defined (pointing to a locally built bspack for now). Example usage calls can be found in the script comments.

Also, the 406 script takes the version from the reason.json file (since it looks like the source of truth for Reason version numbers). Easier for the user to not make mistakes.

Any feedback would be valuable.

@thangngoc89

@ryyppy
Copy link
Contributor Author

ryyppy commented Nov 22, 2019

@jordwalke I think this is ready to be merged. I looked through @jaredly's old PR regarding his esy setup (#2153), but it seems that 1) there's still something broken with the menhir dep 2) it's a more complex change for me and I can't tell how much effort it will take to get this working without shaving a yak.

This solution is definitely working for BS contributors (the target group of this change anyways). Happy to improve things in the future as soon as we figured out what is needed?

\cc @chenglou just for good measure

@jordwalke
Copy link
Member

Sounds good! If the bs-contributors are happy with the workflow, then it does the job well! Most important thing is that it's correct. Thanks for the contribution.

@jordwalke jordwalke merged commit b6b3546 into reasonml:master Dec 1, 2019
@ryyppy ryyppy deleted the bspack-406 branch December 1, 2019 00:28
@jordwalke
Copy link
Member

Thanks @ryyppy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants