-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal] get the reason bspack build script working with esy #2153
Open
jaredly
wants to merge
33
commits into
reasonml:master
Choose a base branch
from
jaredly:joo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
8f195cf
almost to jsoo
jaredly e660347
gettin it workin
jaredly 1675c55
working with esy
jaredly 79fa2cc
ignore
jaredly a9925c5
cleanup
jaredly d118601
more cleanup
jaredly b9f17a8
more cleanup
jaredly d4461ad
version default
jaredly 9677c52
locks
jaredly 5eb1090
vendor bspack
jaredly e876003
missed that too
jaredly a912b5e
cleanup
jaredly 4c709b3
gnu sed
jaredly 1aca9a2
fix version number
jaredly 22a520c
Merge branch 'master' into joo. Conflicts: bspacks/reason_bspack.sh
jchavarri 23d08c1
Add ppx_derivers to bspacks deps
jchavarri 28e4c96
Fix paths to esy sandbox
jchavarri 1d05e43
Native build passing
jchavarri 7b335f1
Fix refmt_js api
jchavarri d667cb8
Merge pull request #2 from jchavarri/joo
jaredly e92ca99
quiet esy.lock
jaredly 9c0248d
get bspack.ml from github
jchavarri 74e623a
actually remove bspack and fix paths
jchavarri 20a8f01
Merge pull request #3 from jchavarri/joo
jaredly 6a8a441
Merge branch 'master' into joo
jaredly a56fc71
igonre output directory
jaredly 5b79c17
use sandboxes! yay
jaredly b5d3aef
rm old
jaredly 458baa1
Merge branch 'master' into joo
jaredly fd11d9d
simplify
jaredly 654f582
generated
jaredly dbd1034
undo that
jaredly e3eec8a
do the prerelease thing
jaredly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
bspack.exe | ||
bin/*.o | ||
bin/*.cm* |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{ | ||
"name": "get-js-of-ocaml", | ||
"notes": "This is to get js_of_ocaml", | ||
"private": true, | ||
"version": "3.3.3", | ||
"dependencies": { | ||
"@opam/js_of_ocaml": "*", | ||
"@opam/menhir": " >= 20170418.0.0 <= 20171013.0.0", | ||
"@opam/ocaml-migrate-parsetree": "*" | ||
}, | ||
"peerDependencies": { | ||
"ocaml": "4.2.3004" | ||
}, | ||
"devDependencies": { | ||
"ocaml": "~4.2.3004" | ||
}, | ||
"esy": { | ||
"build": [ | ||
["echo", "No-op"] | ||
], | ||
"_dependenciesForNewEsyInstaller": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This shouldn't be needed. Was it? It was just a hack for some special cased packages to make sure some old projects will continue to install correctly. It no longer applies. |
||
"@opam/js_of_ocaml": "*", | ||
"@opam/menhir": " >= 20170418.0.0 <= 20171013.0.0", | ||
"@opam/ocaml-migrate-parsetree": "*" | ||
} | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peerDependencies are now no longer needed. The constraint solver fixed that ;)