Explicit long identifiers on parser #1739
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| .. | ||
| end | ||
|
|
||
| parse_tree.mli | ||
| -------------- | ||
| and core_type = { | ||
| ptyp_desc: core_type_desc; | ||
| ptyp_loc: Location.t; | ||
| Parsetree.ptyp_desc: core_type_desc; |
There was a problem hiding this comment.
You only need to do this on one of the record labels. I notice you've done it twice in several cases.
There was a problem hiding this comment.
Want to make sure you just do it at most once per record? (It will help reduce merge conflicts).
According to a
TODOcomment on parser, in order to achieve best maintainability, Allopendeclarations should be removed one by one.I've removed all except
Migrate_parsetree.OCaml_404.Ast, which seems a lot more complex than others and will be in another PR.I've specified long identifiers for the expressions OCaml wasn't able to find explicity, thus fixing all these compilation issues.
make buildis working and all tests viamake testare passing. I've also replaced theTODOby the next task.