This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
fix(syntaxes/reason-md): fewer false positives #251
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses, but does not fully close, issue #250.
VSCode uses Java-syntax regex instead of JS for some reason? Also, you need to escape
\
characters because this is a JSON file. Finally, I am not sure what thebegin
is actually relevant to. However, the upshot is that using word boundary (\b
) cuts down on the number of false positive hits on the ReasonML markdown code block syntax highlighting due to "re" etc. appearing anywhere in the code fence.Maddeningly, I couldn't figure out what secret sauce would actually match on the starting triple-backtick, so stuff like this still triggers the syntax highlighting:
At some point I or someone else will have to figure out a proper regex for this. But for now this PR helps in many cases.