Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

fix(syntaxes/reason-md): fewer false positives #251

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

glebec
Copy link

@glebec glebec commented Sep 12, 2018

Addresses, but does not fully close, issue #250.

VSCode uses Java-syntax regex instead of JS for some reason? Also, you need to escape \ characters because this is a JSON file. Finally, I am not sure what the begin is actually relevant to. However, the upshot is that using word boundary (\b) cuts down on the number of false positive hits on the ReasonML markdown code block syntax highlighting due to "re" etc. appearing anywhere in the code fence.

Maddeningly, I couldn't figure out what secret sauce would actually match on the starting triple-backtick, so stuff like this still triggers the syntax highlighting:

some re stuff
f >=> g

At some point I or someone else will have to figure out a proper regex for this. But for now this PR helps in many cases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant