Always unpacking JVM native lib when using SNAPSHOT version #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1715
This was tested locally by adding a JVM test that checks the schema version
assertEquals(realm.schemaVersion(), 42)Then on AS edit the Core method
realm_get_schema_version(inside https://github.com/realm/realm-core/blob/master/src/realm/object-store/c_api/schema.cpp#L52-L56) to return a different version which should compile a new native shared library to be extracted which has the new value. Observe that the test passes with the modified version .Note: Obviously If you edit the
buildSrc/src/main/kotlin/Config.ktto use a named version locally this work around won't work