Using library version to unpack JVM libs #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for JVM targets
cmelchior
suggested changes
Jan 22, 2024
CHANGELOG.md
Outdated
| @@ -28,6 +28,7 @@ | |||
| ### Internal | |||
| * Update to Ktor 2.3.4. | |||
| * Updated to CMake 3.27.7 | |||
| * The Unpacking of JVM native library will use the current library version instead of a calculated hash for the path. | |||
There was a problem hiding this comment.
Should this be moved to the public part of the changelog? At least it seems like it might have an impact on people that might depended on the old behavior and now need to manually put files in some other location (if they did that before)
packages/cinterop/build.gradle.kts
Outdated
| defaultConfigs { | ||
| buildConfigField(Type.STRING, "version", Realm.version) | ||
| } | ||
| } |
packages/cinterop/build.gradle.kts
Outdated
| @@ -792,3 +749,12 @@ tasks.named("clean") { | |||
| delete(project.file(".cxx")) | |||
| } | |||
| } | |||
|
|
|||
| // Generate an object holding the current release version, to be used by the JVM SoLoader path construction | |||
| buildkonfig { | |||
There was a problem hiding this comment.
This is already being generated by cinterop here: https://github.com/realm/realm-kotlin/blob/main/packages/cinterop/build.gradle.kts#L796, so I do not think you need to add this plugin for it?
| libraryHash + File.separator + | ||
| platform.defaultSystemLocation + | ||
| File.separator + | ||
| LibraryConfig.version + |
There was a problem hiding this comment.
See comment about this already being created by our cinterop library
nhachicha
force-pushed
the
nh/jvm_check_flag
branch
from
e6b9042
to
f7be787
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using library version to build a path where to unpack native libraries for JVM targets
Fixes #1617