Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Realm Kotlin 2.0.0 #48

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Upgrade to Realm Kotlin 2.0.0 #48

merged 5 commits into from
Jun 4, 2024

Conversation

rorbech
Copy link
Contributor

@rorbech rorbech commented May 24, 2024

No description provided.

@cla-bot cla-bot bot added the cla: yes label May 24, 2024
@rorbech rorbech marked this pull request as ready for review May 24, 2024 13:51
Copy link
Contributor

@clementetb clementetb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 great!

// For some reason libsx.plugins.realm does not resolve directly so go through the provider
id(libsx.plugins.realm.get().pluginId)
// For some reason this does not resolve even though [id: 'org.jetbrains.kotlin.native.cocoapods', version: '2.0.0'] is available in Gradle plugin portal
// alias(libsx.plugins.cocoapods)
kotlin("native.cocoapods")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be added to the versions catalog?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The comment above states why.

@@ -39,7 +42,7 @@ kotlin {
implementation("io.ktor:ktor-client-content-negotiation:$ktorVersion")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be added to the catalog too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main idea with doing the catalog was to make it easy to bump the major components (Kotlin, AGP, Realm, etc.) across all samples in the repository. I have added these to the catalogs know, but there are still an awful lot of dependencies and constants that are not in the catalog. We can address these along the way when we have to bump them.

Copy link
Collaborator

@nhachicha nhachicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

AppServicesUsageSamples/settings.gradle.kts Show resolved Hide resolved
alias(libsx.plugins.kotlinMultiplatform)
alias(libsx.plugins.androidLibrary)
alias(libsx.plugins.kotlinSerialization)
// For some reason libsx.plugins.realm does not resolve directly so go through the provider
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because you were using snapshot and it was not published on Gradle portal?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It cannot verify the version when the plugin is already on the classpath. I could remote the classpath entry now that we have a released version, but a bit tedious if we want to do back and forth between snapshot/non-snapshot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it as is to ease working with snapshots, but added a comment.

@rorbech rorbech merged commit be26dc9 into main Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants