Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sync sample to Realm Kotlin 1.4.0 #31

Merged
merged 6 commits into from
Oct 18, 2022
Merged

Update Sync sample to Realm Kotlin 1.4.0 #31

merged 6 commits into from
Oct 18, 2022

Conversation

cmelchior
Copy link
Contributor

@cmelchior cmelchior commented Oct 12, 2022 •
edited
Loading

This PR improves the Sync demo:

  • Updating to Realm Kotlin 1.4.0 including all dependencies
  • Use Flexible Sync instead of Partition-based Sync

TODO

  • Add "offline" button to demonstrate offline merge behavior.

@cla-bot cla-bot bot added the cla: yes label Oct 12, 2022
@cmelchior cmelchior mentioned this pull request Oct 12, 2022
Closed
@cmelchior cmelchior marked this pull request as ready for review October 13, 2022 20:20
@cmelchior cmelchior requested review from nhachicha and rorbech and removed request for nhachicha October 13, 2022 20:20
@cmelchior
Copy link
Contributor Author

This is ready for review, but we probably shouldn't merge until we have a full 1.4.0 release

@nhachicha nhachicha merged commit e64566f into main Oct 18, 2022
@nhachicha nhachicha deleted the cm/realm-kotlin-1.4.0-sync branch October 18, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhachicha nhachicha nhachicha approved these changes

@rorbech rorbech Awaiting requested review from rorbech

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmelchior @nhachicha