Add arm64 variant build #5135
Merged
Add arm64 variant build #5135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kneth
reviewed
Nov 23, 2022
cmake/aarch64.toolchain.cmake
Outdated
| @@ -0,0 +1,16 @@ | |||
| set(CMAKE_SYSTEM_NAME Linux) | |||
There was a problem hiding this comment.
Should this file be in core instead?
There was a problem hiding this comment.
I wasn't sure how easy it would be to get it there, and it would be good to see it work here first. If it is easy to get it into core and then update core in realm-js we can do it that way.
There was a problem hiding this comment.
I agree, we should just add this file to Core, even if Core's CI won't use it just yet.
fealebenpae
requested changes
Nov 23, 2022
cmake/aarch64.toolchain.cmake
Outdated
| @@ -0,0 +1,16 @@ | |||
| set(CMAKE_SYSTEM_NAME Linux) | |||
There was a problem hiding this comment.
I agree, we should just add this file to Core, even if Core's CI won't use it just yet.
0ed78dd
to
9d959bf
Compare
9d959bf
to
ae61d48
Compare
fealebenpae
approved these changes
Nov 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.