Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Realm Peer Dependency in @realm/react #4640

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Fix Realm Peer Dependency in @realm/react #4640

merged 3 commits into from
Jun 13, 2022

Conversation

takameyer
Copy link
Contributor

@takameyer takameyer commented Jun 10, 2022 •
edited
Loading

What, How & Why?

The dependency range did not support -rc versions of Realm.

This closes #4621

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Jun 10, 2022
@takameyer
Fix Realm Peer Dependency in @realm/react
3cbead2 
The dependency range did not support `-beta` versions of Realm.
kraenhansen
kraenhansen reviewed Jun 11, 2022
View reviewed changes
Copy link
Member

@kraenhansen kraenhansen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the code is dependent on the addListener on App which isn't available in 10.20.0-beta.5 (or below), perhaps we'd really want this to be 11.0.0-rc instead?

@takameyer takameyer merged commit cb9b955 into master Jun 13, 2022
@takameyer takameyer deleted the andrew/rr-fix-dep branch June 13, 2022 11:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

10.20.0-beta.5 Missing Constructor Error
2 participants
@takameyer @kraenhansen