Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaulting to host ip when running integration tests on React Native Android #4635

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Defaulting to host ip when running integration tests on React Native Android #4635

merged 2 commits into from
Jun 9, 2022

Conversation

kraenhansen
Copy link
Member

What, How & Why?

This closes an issue making the Android tests fail when ran locally.

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 🔀 Executed flexible sync tests locally if modifying flexible sync
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

@kraenhansen kraenhansen self-assigned this Jun 9, 2022
@cla-bot cla-bot bot added the cla: yes label Jun 9, 2022
takameyer
takameyer approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Approved. How did this work before?

@kraenhansen
Copy link
Member Author

I'm asking myself the same question.
I believe you'd have to set this using the mocha context before running it:

MOCHA_REMOTE_CONTEXT="realmBaseUrl=https://10.0.2.2:9000"

@kraenhansen kraenhansen merged commit 79ea96f into master Jun 9, 2022
@kraenhansen kraenhansen deleted the kh/integration-tests-default-android-ip branch June 9, 2022 11:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@takameyer takameyer takameyer approved these changes

@kneth kneth kneth approved these changes

Assignees

@kraenhansen kraenhansen

Labels
cla: yes T-Internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kraenhansen @takameyer @kneth