callFunction argument validation #4626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
reviewed
Jun 8, 2022
tests/js/user-tests.js
Outdated
| @@ -332,7 +332,7 @@ module.exports = { | |||
| let credentials = Realm.Credentials.anonymous(); | |||
| let user = await app.logIn(credentials); | |||
|
|
|||
| TestCase.assertEqual(await user.callFunction("sumFunc"), 0); | |||
| TestCase.assertEqual(await user.callFunction("sumFunc", 123), 0); | |||
There was a problem hiding this comment.
I would expect this to throw?
There was a problem hiding this comment.
Good catch. I forgot to clean this up.
kraenhansen
approved these changes
Jun 8, 2022
takameyer
force-pushed
the
andrew/bug-4623
branch
from
bce9682
to
150e66d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
A segmentation fault occurs when calling
callFunctionwith invalid arguments.This closes #4623
☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: