Backport of NotificationBucket
#4550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fronck
reviewed
May 3, 2022
fronck
reviewed
May 3, 2022
fronck
reviewed
May 3, 2022
fronck
reviewed
May 3, 2022
fronck
reviewed
May 3, 2022
fronck
approved these changes
May 3, 2022
takameyer
approved these changes
May 3, 2022
| */ | ||
| inline static TokensMap& get_tokens() | ||
| { | ||
| static TokensMap s_tokens; |
There was a problem hiding this comment.
[question] I just am curious what s_ indicates? (Probably something about it being static). I would also like to know how this does get initialised. Does static in this case behave a bit like a singleton?
There was a problem hiding this comment.
Probably something about it being static.
Right. I personally don't like this convention, but I believe it got introduced in the previous implementation because other pieces of the code adhered to it.
I would also like to know how this does get initialised.
This is the initialisation - this syntax calls the default constructor with no arguments.
Co-authored-by: FFranck <[email protected]> Co-authored-by: Andrew Meyer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
This is a backport of #4228 onto
master, in an attempt to ease the rebase ofv11once #4522 is merged tomasterand released.☑️ ToDos
Compatibilitylabel is updated or copied from previous entryBreakinglabel has been applied or is not necessary