Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type for add #4479

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix type for add #4479

merged 1 commit into from
Apr 7, 2022

Conversation

takameyer
Copy link
Contributor

What, How & Why?

The type wasn't working for class based models, only string.

This closes #4477

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

@cla-bot cla-bot bot added the cla: yes label Apr 6, 2022
@kraenhansen
Copy link
Member

kraenhansen commented Apr 6, 2022 •
edited
Loading

Since we're not really using T it might as well be Realm.Result<unknown> and the type parameter can be removed entirely?

@takameyer takameyer merged commit 3624209 into master Apr 7, 2022
@takameyer takameyer deleted the andrew/fix-sync-type branch April 7, 2022 12:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomduncalf tomduncalf tomduncalf approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type error for mutableSubs.add with a collection referencing class based models
3 participants
@takameyer @kraenhansen @tomduncalf