Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting check for C++ code #4096

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Add linting check for C++ code #4096

merged 4 commits into from
Nov 23, 2021

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Nov 22, 2021 •
edited
Loading

What, How & Why?

This adds checking C++ code against the clang-format rules to our GHA lint CI

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

realm-ci and others added 2 commits November 22, 2021 15:57
@realm-ci
Add core .clang-format and clang-format all cpp/hpp files
ff52a40 
Using: for i in `find src -name "*.?pp" | grep -v catch`;  do echo $i; clang-format --style=file $i -i; done
Add linting check for C++ code
70ae841
takameyer
takameyer approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@takameyer takameyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@cla-bot cla-bot bot added the cla: yes label Nov 23, 2021
Base automatically changed from td/clang-format to master November 23, 2021 14:52
@tomduncalf tomduncalf merged commit f38d8cf into master Nov 23, 2021
@tomduncalf tomduncalf deleted the td/clang-format-ci branch November 23, 2021 14:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@takameyer takameyer takameyer approved these changes

@kraenhansen kraenhansen kraenhansen approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tomduncalf @takameyer @kraenhansen @realm-ci