Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core .clang-format and format all source #4087

Merged
merged 1 commit into from
Nov 23, 2021
Merged

Conversation

tomduncalf
Copy link
Contributor

@tomduncalf tomduncalf commented Nov 17, 2021

What, How & Why?

Add consistent formatting to our C++ files using the same .clang-format as core

Applied to existing files using for i in `find src -name "*.?pp" | grep -v catch`; do echo $i; clang-format --style=file $i -i; done from the root directory

☑️ ToDos

  • 📝 Changelog entry
  • 📝 Compatibility label is updated or copied from previous entry
  • 🚦 Tests
  • 📱 Check the React Native/other sample apps work if necessary
  • 📝 Public documentation PR created or is not necessary
  • 💥 Breaking label has been applied or is not necessary

If this PR adds or changes public API's:

  • typescript definitions file is updated
  • jsdoc files updated
  • Chrome debug API is updated if API is available on React Native

Using: for i in `find src -name "*.?pp" | grep -v catch`;  do echo $i; clang-format --style=file $i -i; done
@tomduncalf tomduncalf marked this pull request as ready for review November 23, 2021 10:05
@tomduncalf tomduncalf merged commit fa80f12 into master Nov 23, 2021
@tomduncalf tomduncalf deleted the td/clang-format branch November 23, 2021 14:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants