Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROS dependency in release notes #2405

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Fix ROS dependency in release notes #2405

merged 2 commits into from
Jun 11, 2019

Conversation

bmunkholm
Copy link
Contributor

@bmunkholm bmunkholm commented Jun 6, 2019

The template for release notes did not update the ROS dependency and subsequent release notes were wrong on that point.

I've updated the Releases (where the release notes were published) manually.

@kneth
Copy link
Member

kneth commented Jun 7, 2019

@bmunkholm Thank you. I have apparently missed that when I did the last releases 😢.

@bmunkholm
Copy link
Contributor Author

so did the reviewers :-)

@bmunkholm
Copy link
Contributor Author

@kneth Are the unstable tests tracked? :


  •                Failures                    *
    

  1. Adapter should collapse schema changes into the table creation
  • Notification not recieved thrown

@kneth
Copy link
Member

kneth commented Jun 7, 2019

@bmunkholm We haven't looked much into the test situation recently (after the merge of realm-js-private). In particular React Native and Linux test environments seem to suffer from race conditions, and my hunch is that our test framework is to blame.

@bmunkholm bmunkholm merged commit 495b12f into master Jun 11, 2019
@bmunkholm bmunkholm deleted the bmunkholm-patch-1 branch June 11, 2019 05:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants