Skip to content

Commit

Permalink
Use the CentOS 7 based container to build for Linux x64
Browse files Browse the repository at this point in the history
This is to avoid linking to newer Glibc versions causing errors on older Linux
distros as seen in #5006
  • Loading branch information
iamer committed Oct 27, 2022
1 parent 895ea32 commit 7571171
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/pr-realm-js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,16 @@ jobs:
build:
name: Build for ${{ matrix.variant.os }} ${{ matrix.variant.arch }}
runs-on: ${{ matrix.variant.runner }}
# if container is not set for a variant, this is a noop
container: ${{ matrix.variant.container }}
env:
REALM_DISABLE_ANALYTICS: 1
NDK_VERSION: 21.0.6113669
strategy:
fail-fast: false
fail-fast: true
matrix:
variant:
- { os: linux, runner: ubuntu-latest, arch: x64, artifact-path: prebuilds, test-node: true, test-electron: true }
- { os: linux, runner: ubuntu-latest, arch: x64, artifact-path: prebuilds, test-node: true, test-electron: true, container: "ghcr.io/realm-js/linux-x64:master" }
- { os: windows, runner: windows-latest, arch: x64, artifact-path: prebuilds, test-node: true, test-electron: true }
- { os: windows, runner: windows-2019, arch: ia32, artifact-path: prebuilds }
- { os: android, runner: ubuntu-latest, arch: x86_64, artifact-path: react-native/android/src/main/jniLibs }
Expand Down Expand Up @@ -87,7 +89,7 @@ jobs:
# On linux, electron requires a connected display. We fake this by giving it a headless environment using xvfb
# Relevant issue: https://github.com/juliangruber/browser-run/issues/147
- name: Linux Environment setup
if: ${{ (matrix.variant.runner == 'ubuntu-latest') }}
if: ${{ (matrix.variant.runner == 'ubuntu-latest') && (matrix.variant.container == '') }}
run: sudo apt-get install ccache ninja-build

- name: Setup Java
Expand Down

0 comments on commit 7571171

Please sign in to comment.