Error Frames and User Image Invalidation #1604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikeb01
commented
May 24, 2024
mikeb01
commented
- Support the ability to allow a user to invalidate an image within a subscription.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mikeb01
force-pushed
the
feature/error_frames
branch
from
ce58a33
to
6bda98e
Compare
mikeb01
changed the title
mikeb01
force-pushed
the
feature/error_frames
branch
from
5f4396c
to
574e267
Compare
|
|
||
| public void onPublicationError(final PublicationErrorFrame errorFrame) | ||
| { | ||
| errorFrameQueue.offer(errorFrame.clone()); |
Check notice
Code scanning / CodeQL
Ignored error status of call Note
aeron-driver/src/main/java/io/aeron/driver/status/SystemCounterDescriptor.java
Outdated
Show resolved
Hide resolved
…ode. Prevent new data being inserted into an invalidated image. Add logging.
…e is found during invalidation on the receiver.
… have it disconnect. Allow receiver side image to linger to prevent immediately recreation of the image. Treat errors received by the NetworkPublication to behaviour like end of stream messages.
…t send max frame size each time.
… Check that we don't spam out error messages too quickly. Reset timestamp of last SM sent by the publication image when sending errors.
…eck that we don't spam out error messages too quickly. Reset timestamp of last SM sent by the publication image when sending errors.
…t on invalidate image.
…lication registered.
…n object to be reported to the caller.
mikeb01
force-pushed
the
feature/error_frames
branch
from
cb113e8
to
e6f62bb
Compare
mjpt777
reviewed
Jul 4, 2024
mjpt777
reviewed
Jul 4, 2024
mjpt777
reviewed
Jul 4, 2024
| */ | ||
| public static final int MAX_ERROR_MESSAGE_LENGTH = 1023; | ||
|
|
||
| public static final int MAX_ERROR_FRAME_LENGTH = HEADER_LENGTH + MAX_ERROR_MESSAGE_LENGTH; |
mjpt777
reviewed
Jul 4, 2024
| */ | ||
| public String errorMessage() | ||
| { | ||
| return getStringUtf8(ERROR_STRING_FIELD_OFFSET); |
There was a problem hiding this comment.
It would be better to treat encoded strings at US_ASCII as this is consistent elsewhere and ports to C.
mjpt777
reviewed
Jul 4, 2024
| /** | ||
| * A count of the number of error frames received by this driver. | ||
| */ | ||
| ERROR_FRAMES_RECEIVED(38, "Error Frames received"); |
There was a problem hiding this comment.
Should we have a corresponding error frames sent counter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.