Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E i j transfer #352

Merged
merged 11 commits into from
Feb 11, 2019
Merged

E i j transfer #352

merged 11 commits into from
Feb 11, 2019

Conversation

mira-gruenwald
Copy link
Collaborator

finished Transfer E, I and J

most of these Acts need to be checked! See #299 (I put the number of the issue in the Comment line of the Acts)
Checked Landport and corrected it. Close #350
close #341 .

Checklist

  • The title line explains what these changes do
  • All my changes are marked in the last_modfied column
  • The PR has no merge conflicts
  • Travis checks are passing

duncdrum
duncdrum requested changes Feb 11, 2019
View reviewed changes
Copy link
Member

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small changes (you should be able to accept them right from the webpage here)

data/Place.csv Outdated
@@ -329,12 +329,12 @@ PL0415,Hubei,37.59857,114.60758,,2018-11-09,MG,2018-11-09,MG
PL0416,Warszawa ,52.229675,21.01223,,2018-11-09,MG,2018-11-09,MG
PL0417,Pescasseroli,41.80825,13.78958,,2018-11-09,MG,2018-11-09,MG
PL0999,unknown,0,0,,2018-11-13,MG,2018-11-13,MG
PL0314,Hejin,35.596,110.712,,2018-11-15,DM,2018-11-15,DM
PL0314,Hejin,35596,110712,,2018-11-15,DM,2018-11-15,DM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look right

data/Place.csv Outdated
PL0315,Litomyšl,49.87,16.312778,,2018-11-17,DM,2018-11-17,DM
PL0316,Haining,30.5107,120.6808,,2019-01-07,DM,2019-01-07,DM
PL0317,Blankenburg,51.8164,10.9773,,2019-01-08,DM,2019-01-08,DM
PL0318,Salinas,36.6777,121.6555,,2019-01-08,DM,2019-01-08,DM
PL0319,Letychiv,49.385,27.6242,,2019-01-08,DM,2019-01-08,DM
PL0319,Letychiv,49385,27.6242,,2019-01-08,DM,2019-01-08,DM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.a.

data/Place.csv Outdated Show resolved Hide resolved
data/Place.csv Outdated Show resolved Hide resolved
@duncdrum duncdrum added this to In progress in Progress Indicator Transfers Feb 11, 2019
duncdrum and others added 2 commits February 11, 2019 12:41
@duncdrum @mira-gruenwald
Update data/Place.csv
02928a7 
Co-Authored-By: mira-gruenwald <[email protected]>
@duncdrum @mira-gruenwald
Update data/Place.csv
1aa6809 
Co-Authored-By: mira-gruenwald <[email protected]>
@duncdrum duncdrum merged commit 8f89e3b into master Feb 11, 2019
Progress Indicator Transfers automation moved this from In progress to Done Feb 11, 2019
@duncdrum duncdrum deleted the E-I-J-Transfer branch February 11, 2019 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncdrum duncdrum duncdrum approved these changes

@damianodamiani damianodamiani Awaiting requested review from damianodamiani

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Progress Indicator Transfers
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Place: Landport Transfer E I J
2 participants
@mira-gruenwald @duncdrum