[#2PlaysAMonth]: Dad Jokes #942
Conversation
|
@Bobby-coder is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 😊.
Please reference the issue number in the description if you are fixing a bug.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.
Stale Marking : After 30 days of inactivity this PR will be marked as stale PR and it will be closed and locked in 7 days if no further activity occurs.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
You have put a great effort on this one @Bobby-coder Good Job.
Please take care of the review comments. Also try reducing the size of the cover image. Its more than 4MB now.. Try making it in KBS for faster loading in a slow network.
I'll merge this one sooner you address all the comments. Good Luck!
|
@Bobby-coder Is it ready for a final review? Have you taken care of all the comments? |
Yes it is ready for the final review |
There was a problem hiding this comment.
@Bobby-coder Great Job. LGTM.
Do not forget to share it with the world.. and if you do so, please tag #2PlaysAMonth and ReactPlayIO. This play will be available on the ReactPlay in 10 minutes after a successful build.
Looking forward to the second one!
Sure 😊 |
Dad Jokes
Dad Jokes is a fully functional react app which offers the various categories of jokes to enjoy.
Fixes #930
Type of change
How Has This Been Tested?
It is tested locally.
Checklist: