Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: removed extra fault payload code in filter #872

Merged
merged 1 commit into from
Jan 16, 2023
Merged

[FIX]: removed extra fault payload code in filter #872

merged 1 commit into from
Jan 16, 2023

Conversation

supminn
Copy link
Contributor

@supminn supminn commented Jan 13, 2023

Description

While creating the JSON payload for filtering plays based on multiple filters, we add a conditional clause for the production environment. This clause helps us remove the plays that are in dev_mode.
The conditional clause was incorrectly added in 2 places.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I have verified it by setting the env conditions to mimic the activity on production.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings

@vercel
Copy link

vercel bot commented Jan 13, 2023

@supminn is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@atapas
Copy link
Member

atapas commented Jan 13, 2023

@Angryman18 review plz

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
react-play ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 13, 2023 at 2:54PM (UTC)

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the !preview condition for?

@supminn
Copy link
Contributor Author

supminn commented Jan 14, 2023

What was the !preview condition for?

I am not aware of it. @Angryman18 could you share some light on this variable? It points to process.env.REACT_APP_PREVIEW_MODE;

@Angryman18
Copy link
Member

let me see it. fun fact im facing issues running our app locally from few days.

@atapas
Copy link
Member

atapas commented Jan 15, 2023

@supminn / @Angryman18

Can you please quickly search if REACT_APP_PREVIEW_MODE is being used anywhere else in the app? I feel it was added for the hack-r-play banner.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@atapas atapas merged commit d415477 into reactplay:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: Filter by Play Creator fails
3 participants