Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Play]: Savings Calculator #748

Merged
merged 29 commits into from
Oct 30, 2022
Merged

Conversation

kd100100
Copy link
Contributor

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

A simple savings calculator where one can enter starting balance, monthly contribution, period/tenure and annual interest rate to get the end balance after the period/tenure..

Fixes #746

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested in local environment in cypress. Added unit tests using jest to confirm functionalities are working.

Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Oct 21, 2022

@kd100100 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@kd100100
Copy link
Contributor Author

kd100100 commented Oct 27, 2022

@Sachin-chaurasiya @koustov @atapas Could you please review this?

@vercel
Copy link

vercel bot commented Oct 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 30, 2022 at 5:42AM (UTC)

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial changes.

src/plays/savings-calculator/SavingsCalculator.jsx Outdated Show resolved Hide resolved
src/plays/savings-calculator/SavingsCalculator.jsx Outdated Show resolved Hide resolved
@kd100100
Copy link
Contributor Author

kd100100 commented Oct 27, 2022

Some initial changes.

@Sachin-chaurasiya I have made the changes. Could you please review?

@kd100100
Copy link
Contributor Author

@Sachin-chaurasiya Is it possible to re-review and suggest changes by this month end, so that it can be considered as an hactoberfest contribution once merged?

Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a few final changes.

src/plays/savings-calculator/SavingsCalculator.jsx Outdated Show resolved Hide resolved
src/plays/savings-calculator/components/Total/total.scss Outdated Show resolved Hide resolved
src/plays/savings-calculator/readme.md Show resolved Hide resolved
src/plays/savings-calculator/utils/getCalculatedSaving.js Outdated Show resolved Hide resolved
src/plays/savings-calculator/utils/getCalculatedSaving.js Outdated Show resolved Hide resolved
src/plays/savings-calculator/utils/getCalculatedSaving.js Outdated Show resolved Hide resolved
@Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Is it possible to re-review and suggest changes by this month end, so that it can be considered as an hactoberfest contribution once merged?

@kd100100 , Left a few comments.

@kd100100
Copy link
Contributor Author

@Sachin-chaurasiya Is it possible to re-review and suggest changes by this month end, so that it can be considered as an hactoberfest contribution once merged?

@kd100100 , Left a few comments.

@Sachin-chaurasiya Made the changes! Please re-review!

@Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya Is it possible to re-review and suggest changes by this month end, so that it can be considered as an hactoberfest contribution once merged?

@kd100100 , Left a few comments.

@Sachin-chaurasiya Made the changes! Please re-review!

Great work @kd100100

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@atapas atapas merged commit c3bdbce into reactplay:main Oct 30, 2022
@kd100100 kd100100 deleted the savings-calculator branch October 30, 2022 06:41
@kd100100 kd100100 restored the savings-calculator branch October 30, 2022 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Savings Calculator
3 participants