-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get motivated play #745
Get motivated play #745
Conversation
@Hat52 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Review issues resolved
@Sachin-chaurasiya I have resolved the issues that you have raised. |
@Hat52 , The Preview image is not loading can you check? |
@Sachin-chaurasiya how can I add a preview I have tried to add a cover.png file at the root of my play but it is still not showing. |
@Hat52 , please see the Play structure here |
I have followed the same structure for preview image but it is still not showing. |
@Hat52 , Let's add the cover image and push the change, and then I will have a look. |
@Sachin-chaurasiya I have added the cover image |
@Hat52 , Now preview image is visible, you can check here https://react-play-knusnj94h-reactplayio.vercel.app/ |
@Sachin-chaurasiya yeah I have noticed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hat52 Please add a unique class name infront of your all the styles. It will reduce any chances of style conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hat52 Thanks for making the changes. The images are oversized. Please make them within 100KBs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
Description
Play added #740
Fixes # (issue)
How Has This Been Tested?
Tested on my local
Checklist: