Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get motivated play #745

Merged
merged 10 commits into from
Oct 28, 2022
Merged

Get motivated play #745

merged 10 commits into from
Oct 28, 2022

Conversation

Hat52
Copy link
Contributor

@Hat52 Hat52 commented Oct 21, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Play added #740

Fixes # (issue)

How Has This Been Tested?

Tested on my local

Checklist:

  • [ x] I have performed a self-review of my own code

@vercel
Copy link

vercel bot commented Oct 21, 2022

@Hat52 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 3:05AM (UTC)

src/common/playcreated/play-created.scss Outdated Show resolved Hide resolved
src/plays/motivate-me/MotivateMe.js Outdated Show resolved Hide resolved
src/plays/motivate-me/components/cards/index.css Outdated Show resolved Hide resolved
src/plays/motivate-me/components/footer/index.js Outdated Show resolved Hide resolved
src/plays/motivate-me/MotivateMe.js Outdated Show resolved Hide resolved
src/plays/motivate-me/index.css Outdated Show resolved Hide resolved
Review issues resolved
@Hat52
Copy link
Contributor Author

Hat52 commented Oct 21, 2022

@Sachin-chaurasiya I have resolved the issues that you have raised.

@Sachin-chaurasiya
Copy link
Member

@Hat52 , The Preview image is not loading can you check?
image

@Hat52
Copy link
Contributor Author

Hat52 commented Oct 22, 2022

@Sachin-chaurasiya how can I add a preview I have tried to add a cover.png file at the root of my play but it is still not showing.

@Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya how can I add a preview I have tried to add a cover.png file at the root of my play but it is still not showing.

@Hat52 , please see the Play structure here
https://github.com/reactplay/react-play/blob/main/src/plays/clock

@Hat52
Copy link
Contributor Author

Hat52 commented Oct 22, 2022

@Sachin-chaurasiya how can I add a preview I have tried to add a cover.png file at the root of my play but it is still not showing.

@Hat52 , please see the Play structure here https://github.com/reactplay/react-play/blob/main/src/plays/clock

I have followed the same structure for preview image but it is still not showing.

@Sachin-chaurasiya
Copy link
Member

@Sachin-chaurasiya how can I add a preview I have tried to add a cover.png file at the root of my play but it is still not showing.

@Hat52 , please see the Play structure here https://github.com/reactplay/react-play/blob/main/src/plays/clock

I have followed the same structure for preview image but it is still not showing.

@Hat52 , Let's add the cover image and push the change, and then I will have a look.

@Hat52
Copy link
Contributor Author

Hat52 commented Oct 22, 2022

@Sachin-chaurasiya I have added the cover image

@Sachin-chaurasiya
Copy link
Member

@Hat52 , Now preview image is visible, you can check here https://react-play-knusnj94h-reactplayio.vercel.app/

@Hat52
Copy link
Contributor Author

Hat52 commented Oct 22, 2022

@Sachin-chaurasiya yeah I have noticed that.

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hat52 Please add a unique class name infront of your all the styles. It will reduce any chances of style conflicts.

@Hat52
Copy link
Contributor Author

Hat52 commented Oct 27, 2022

@Hat52 Please add a unique class name infront of your all the styles. It will reduce any chances of style conflicts.

@atapas Done

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hat52 Thanks for making the changes. The images are oversized. Please make them within 100KBs

@Hat52
Copy link
Contributor Author

Hat52 commented Oct 27, 2022

@Hat52 Thanks for making the changes. The images are oversized. Please make them within 100KBs

@atapas Each image should be less the 100KBs?

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 28, 2022
@atapas atapas linked an issue Oct 28, 2022 that may be closed by this pull request
1 task
@atapas atapas merged commit 581f271 into reactplay:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add a Play]: Get Motivated
3 participants