[Play] - News Feed Application

[NagarjunShroff]

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
#670

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[vercel]

@NagarjunShroff is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

[github-actions]

Hello! Thank you for your contribution 😊.
Please reference the issue number in the description if you are fixing a bug.
If you are implementing a feature request, please check with the maintainers that the feature will be accepted first.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-play	✅ Ready (Inspect)	Visit Preview	Oct 20, 2022 at 11:41AM (UTC)

[murtuzaalisurti]

@atapas @koustov here email is shown instead of name, is it because of github or user entry?

[murtuzaalisurti]

@NagarjunShroff I am getting a 426 error from the API.

[NagarjunShroff]

@NagarjunShroff I am getting a 426 error from the API.

@murtuzaalisurti Checking...

[atapas]

@atapas @koustov here email is shown instead of name, is it because of github or user entry?

@NagarjunShroff Did you provide your github id while creating the play?

[NagarjunShroff]

@atapas @koustov here email is shown instead of name, is it because of github or user entry?

@NagarjunShroff Did you provide your github id while creating the play?

@atapas, yes i did

[atapas]

Let's wrap up the review and fixes for merge.

[atapas]

@NagarjunShroff Have we added the API key in vercel?

[NagarjunShroff]

@NagarjunShroff Have we added the API key in vercel?

No we haven't added it - Could you please add it?

[murtuzaalisurti]

@atapas api key needs to be added I guess

[murtuzaalisurti]

error on load, probably because of api key

[atapas]

Visit Preview

I remember adding it. I shall check again. Irrespective of it, we need to handle the error messages correctly!

Due to some reasons, the newsData is undefined and breaks! The reason can be anything, including there are no API keys. Let's handle the error message correctly @NagarjunShroff

 <div className="card-container">
              {newsData.length > 0 ? (
                newsData.map((news, i) => <NewsCard news={news} key={i} />)
              ) : (
                <CircularProgress />
              )}
 </div>

[koustov]

{"status":"error","code":"corsNotAllowed","message":"Requests from the browser are not allowed on the Developer plan, except from localhost."}

The free key cannot be used on a production server. So @NagarjunShroff what needs to be done for this play?

[NagarjunShroff]

{"status":"error","code":"corsNotAllowed","message":"Requests from the browser are not allowed on the Developer plan, except from localhost."}

The free key cannot be used on a production server. So @NagarjunShroff what needs to be done for this play?

@koustov, if APIs don't work- We can ignore it play.

[atapas]

@NagarjunShroff

Why shelve the hard work?

Can you repurpose it using the free API?

Here is an example: https://saurav.tech/NewsAPI/

[NagarjunShroff]

@NagarjunShroff

Why shelve the hard work?

Can you repurpose it using the free API?

Here is an example: https://saurav.tech/NewsAPI/

Thanks!!! @atapas, Sure will do it.

[NagarjunShroff]

Ready for review.

[NagarjunShroff]

@atapas Please review.

[atapas]

Looks good

[koustov]

lgtm