Fix: heading level hierarchy #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EmmaDawsonDev is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel. @reactplay first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@koustov Please review this one. Also need to test the changes as some hierarchy changes may disturb CSS(speculating). |
koustov
requested changes
Oct 8, 2022
|
Sure, this one? |
@koustov It says LGTM but not approved. Any reason? |
|
@EmmaDawsonDev Time to resolve the conflict of this one. |
|
All fixed :) |
|
Anything else that needs doing? |
|
@koustov Please approve and merge it. |
Will finish by EOD today |
Must have selected the wrong radion button :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The headings were not following the correct hierarchy on all pages. In some places there was no h1, in other places it jumped over levels.
Fixes #580
Type of change
Headings are now semantically correct on all pages. Styling remained the same due to good use of classes for styling.
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Visual. Axe Dev Tools
Checklist: