Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #643: div tag present as descendant of p tag #644

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

SSK-14
Copy link
Contributor

@SSK-14 SSK-14 commented Oct 8, 2022

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

div tag cannot appear as a descendant of p tag
p tag can only contain inline elements and div tag is a block element.
Putting a div tag inside it is improper.

Fixes # (643)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Oct 8, 2022

@SSK-14 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@atapas atapas requested a review from Angryman18 October 8, 2022 13:53
@atapas
Copy link
Member

atapas commented Oct 8, 2022

@Angryman18 please review this one.

@Angryman18
Copy link
Member

deploy it

@vercel
Copy link

vercel bot commented Oct 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 8, 2022 at 7:13PM (UTC)

@koustov
Copy link
Member

koustov commented Oct 8, 2022

deploy it

deployment approved

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 9, 2022
Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting

@atapas atapas merged commit d283384 into reactplay:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug report]: div tag cannot appear as a descendant of p tag
4 participants