Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load contributor images #640

Merged
merged 7 commits into from
Oct 9, 2022

Conversation

abhi-works
Copy link
Contributor

@abhi-works abhi-works commented Oct 7, 2022

lazy load contributor images

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

lazy load contributor images
@vercel
Copy link

vercel bot commented Oct 7, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

@abhi-works
Copy link
Contributor Author

#639 linked to this issue @atapas

@Angryman18
Copy link
Member

@atapas deploy

@vercel
Copy link

vercel bot commented Oct 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ✅ Ready (Inspect) Visit Preview Oct 8, 2022 at 7:19PM (UTC)

abhi-works and others added 2 commits October 8, 2022 11:18
Extending lazy loading to play covers and github avatars
@abhi-works
Copy link
Contributor Author

abhi-works commented Oct 8, 2022

Extended this feature to lazy load thumbnail cover images and user avatars and ready for review

@atapas atapas requested a review from Angryman18 October 8, 2022 12:19
@Angryman18
Copy link
Member

deploy it

Copy link
Member

@koustov koustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted

@atapas atapas added the hacktoberfest-accepted hacktoberfest-accepted label Oct 9, 2022
@atapas atapas merged commit 940b913 into reactplay:main Oct 9, 2022
@atapas
Copy link
Member

atapas commented Oct 9, 2022

@all-contributors please add @abhi-works for Code

@allcontributors
Copy link
Contributor

@atapas

I've put up a pull request to add @abhi-works! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Lazy loading of contributor images and play covers
4 participants